Error undefined method `year'

[dodomarocgenex]

I am trying to run a .rb file with the provided examples, but I get this error:

/Users/UserName/.rvm/rubies/ruby-2.4.0/lib/ruby/gems/2.4.0/gems/tickle-1.1.0/lib/tickle/tickle.rb:265:in next_appropriate_year': undefined method year' for nil:NilClass (NoMethodError)

Does it have to do with ruby version?

[Iain Barnett]

Hi,

It's a possibility. I've not run it with 2.4 on my machine as I only installed 2.4 a couple of hours ago :) It seems to have last run on Travis with 2.2.5.

Have you tried using the release candidate? v2.0.0.rc1

I will update the Travis file and give 2.4 a try too.

Regards,
iain

[dodomarocgenex]

I've just installed 2.4 too
Do functions with default values need () in this Ruby version?

[Iain Barnett]

Not that I know of. I just tried a simple one in irb and it was fine. iain

…

On 12 Mar 2017, at 02:36, dodomarocgenex ***@***.***> wrote: I've just installed 2.4 too Do functions with default values need () in this Ruby version? — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[Iain Barnett]

I just ran the tests for v1.1.0 with ruby 2.4 and they passed. Running the examples.rb file, which I hadn't noticed existed tbh, throws up an error. There's barely anything in it though.

Is there a particular example that's not working for you?

iain

[dodomarocgenex]

None of them works 😔

[Iain Barnett]

Hmmm. All the ones I’ve tried in IRB from the README* work for me. Can you try these and see if you get the same results?

irb(main):010:0> Tickle.parse('3 months', {:until=>"2010-10-09 00:00:00 -0400"})
=> {:next=>2017-06-12 04:00:04 +0100, :expression=>"3 months", :starting=>2017-03-12 03:00:04 +0000, :until=>nil}
irb(main):011:0> Tickle.parse('every week starting this wednesday ends May 13th')
=> {:next=>2017-03-15 12:00:00 +0000, :expression=>"week", :starting=>2017-03-15 12:00:00 +0000, :until=>2017-05-13 12:00:00 +0100}
irb(main):012:0> Tickle.parse('every other day starting May 13')
=> {:next=>2017-05-13 12:00:00 +0100, :expression=>"other day", :starting=>2017-05-13 12:00:00 +0100, :until=>nil}

* that don’t have silly syntax errors like missing double quotes. Note to self to fix those.

iain

[dodomarocgenex]

Running the examples you've given works just fine in irb, I'm going to look into my .rb file again

[dodomarocgenex]

Trying to to run a simple .rb containing this code:

require 'tickle'

Tickle.parse('starting tomorrow and ending one week from now')

using the command ruby file.rb in the terminal on MacOS Sierra

Gives this error message:

/usr/bin/ruby -e $stdout.sync=true;$stderr.sync=true;load($0=ARGV.shift) /Users/UserName/Desktop/file.rb
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/universal-darwin16/rbconfig.rb:213: warning: Insecure world writable dir /usr/local/bin in PATH, mode 040777
/Library/Ruby/Gems/2.0.0/gems/tickle-1.1.0/lib/tickle/tickle.rb:265:in `next_appropriate_year': undefined method `year' for nil:NilClass (NoMethodError)
	from /Library/Ruby/Gems/2.0.0/gems/tickle-1.1.0/lib/tickle/tickle.rb:208:in `normalize_us_holidays'
	from /Library/Ruby/Gems/2.0.0/gems/tickle-1.1.0/lib/tickle/tickle.rb:176:in `pre_filter'
	from /Library/Ruby/Gems/2.0.0/gems/tickle-1.1.0/lib/tickle/tickle.rb:130:in `scan_expression'
	from /Library/Ruby/Gems/2.0.0/gems/tickle-1.1.0/lib/tickle/tickle.rb:54:in `parse'
	from /Users/UserName/Desktop/file.rb:3:in `<top (required)>'
	from -e:1:in `load'
	from -e:1:in `<main>'

Process finished with exit code 1

[dodomarocgenex]

setting the default ruby version doesn't help either

rvm --default use 2.4

[Iain Barnett]

This fails for me also, with both Ruby v2.2.2 and v2.4.0 It does work when I try it with the release candidate in both of those Rubies. If you can track down the source of the problem, perhaps using Pry or the debugger, that’d be a big help. Otherwise I’d just jump to the rc and see if it fits your use case. iain

…

On 12 Mar 2017, at 12:09, dodomarocgenex ***@***.***> wrote: require 'tickle' Tickle.parse('starting tomorrow and ending one week from now')

[Iain Barnett]

It appears to be in lib/tickle/tickle.rb:265, when `@start.year` is called @start is nil, thus the error is thrown. It’s not chronic’s fault, but the `pre_filter`. I’m going to try and find out why @start is being used this way if the method is trying to set it. I think I removed the US holidays part from the release candidate as I’d prefer it to be a plugin. iain

…

On 12 Mar 2017, at 14:34, dodomarocgenex ***@***.***> wrote: Maybe this is the reason chronic_parse is included in Chronic and it's used here: if starting Tickle.dwrite("starting: #{starting}") @start = chronic_parse(pre_filter(starting)) if @start @start.to_time else raise(InvalidDateExpression,"the starting date expression \"#{starting}\" could not be interpretted") end else @start = options[:start].to_time rescue nil end — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[Iain Barnett]

I've pushed a branch called debugging-with-pry to make it more convenient to debug. Just call env DEBUG=1 bin/pry (if you've installed pry via --binstubs) and then set break points where you like, e.g.

break lib/tickle/tickle.rb:130
break lib/tickle/tickle.rb:176
break lib/tickle/tickle.rb:208
break lib/tickle/tickle.rb:265

They are the ones I'm using right now.

iain

[Iain Barnett]

I've made a change to next_appropriate_year and pushed it to the debug branch. It appears to bring back the right answer and it passes the tests (which doesn't say a lot, the specs on the rc branch are far more comprehensive).

Let me know if it works for you.

iain

[dodomarocgenex]

@start was nil in 1.1.0, I'll run some test on the debugging branch