yashaka / selene

User-oriented Web UI browser tests in Python

Home Page:https://yashaka.github.io/selene/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Fix the DeprecationWarning message for save_page_source method

ksmyshlyaev opened this issue · comments

As of now, the method save_page_source() at the selene -> core -> entity.py:1249 is deprecated and the DeprecationWarning message says

'browser.save_page_source is deprecated, '
'use browser.config.last_screenshot'

which is not relevant and might be confusing.
The suggestion is to change it to

use browser.get(query.page_source_saved())

go for it! waiting for PR