yarpc / yarpc-go

A message passing platform for Go

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

protoc-gen-yarpc-go always generates fx code

robbertvanginkel opened this issue · comments

After #1449, protoc-gen-yarpc-go always generates code for go.uber.org/fx.

We should make the fx code generation optional to not force a dependency on fx when using yarpc. Either through an opt out like--no-fx or opt in like plugins=fx. Leaning towards the second as its similar as how the default go plugin allows you to also generate grpc code.

We may need to use an opt-out to preserve backward compatibility.

In #1449 we talked about adding a --no-fx later, I think this is what you'd want.