protoc-gen-yarpc-go always generates fx code
robbertvanginkel opened this issue · comments
Robbert van Ginkel commented
After #1449, protoc-gen-yarpc-go
always generates code for go.uber.org/fx
.
We should make the fx code generation optional to not force a dependency on fx when using yarpc. Either through an opt out like--no-fx
or opt in like plugins=fx
. Leaning towards the second as its similar as how the default go plugin allows you to also generate grpc code.
Akshay Shah commented
We may need to use an opt-out to preserve backward compatibility.