Using YLMoment as a CocoaPod replaces the app's Localization.strings file with its own
ethereal-engineer opened this issue · comments
A couple of hours of frustration as to why my localised strings were not making it into the app had me eventually pull the app bundle apart to find that the Localizable.strings files were being clobbered by YLMoment's ones. HockeySDK also uses localisation but its files are named HockeySDK.strings and are contained within a separate bundle. I think the fix for this would be to move the NSLocalizedString calls to point to a YLMoment bundle file instead.
Hi,
Indeed, I didn't think about this problem. I'll update that asap (I think tomorrow it'll be fixed).
Thank you for the report. 👍
It should works now.
I moved the localized files into the YLMoment bundle, and I also changed the localized table.
Before to push the new release to the cocoapods spec I would know if it fixes your prob?
Thanks
I'll be able to have a look in about 10 hours (sleep time). I'll get back to you ASAP. Thanks!—
Sent from Mailbox for iPhone
On Fri, Feb 14, 2014 at 1:15 AM, Yannick Loriot notifications@github.com
wrote:
It should works now.
I moved the localized files into the YLMoment bundle, and I also changed the localized table.
Before to push the new release to the cocoapods spec I would know if it fix your prob?Thanks
Reply to this email directly or view it on GitHub:
#6 (comment)
No probs, thank you. 👍
Verified fixed. Thanks so much!
Great! I'll update the cocoapod's spec today. :)