Giters

yangshun / tech-interview-handbook

💯 Curated coding interview preparation materials for busy software engineers

Home Page:https://www.techinterviewhandbook.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Feature Request: Buttons for collapse all/expand all on the Grind75 site

bhuynhdev opened this issue · comments

commented

A collapse all/expand all buttons will really improve UX because on first load, every weekly problem group on Grind75 page is expanded, which makes it a little bit cumbersome to scroll down to Week 6+, and there are no easy ways to collapse all either.

Therefore, I believe having collapse all/expand all buttons along with starting in Collapsed mode would be better

I will be happy to contribute PRs to code (I want to contribute to OSS too) if someone can point me to right file and folder.

commented

Hi @bhuynhdev, thanks for the good feedback. I made it such that completed groups will be collapsed by default, would that be better and do you still need an expand/collapse all feature?

commented

Dear @yangshun "completed groups will be collapsed by default" is definitely much better (can confirm on the live site). Thanks a lot for the quick changes

I still believe that an expand all/collapse all is still very desirable:

  • sometimes I want to know if I have done a problem before (for my own purposes or for showing my friend), or if a particular problem exists in this Grind 75 list. In such case, one thing I do is expand every group and do a Control + F search (since there seems to be no search feature in Grind75). Therefore, a quick Expand all/collapse all button would really be helpful
  • sometimes I just want to expand all for a comprehensive look through of the problems I have solved

Therefore, I believe an expand all/collapse all would still be very beneficial to the UX.

commented

@bhuynhdev That makes sense! Adding the feature is very easy, I'm just not sure where to add the button given the UI is beginning to get quite cluttered. Any suggestions? Maybe beside the "Hide topics" button

commented

I think they would make sense in the left toolbar. Some options are:

  • Right under the sliders in Schedule
  • Or maybe in a separate group called "Controls" below the "Topics" group

And the Expand All/Collapse all don't need to be displayed like buttons (with borders and color fill). I think they can still suffice even if they look just like links.