Maintain
hamiltondanielb opened this issue · comments
I would be willing to maintain, I just forked to create a Line Bar combined chart.
Can I see it ?
ya, i will push something up soon, working through my fork because i wanted d3 v4
Sorry for delay, i am out of the country without great internet, and my honeymoon, will get it up within shortly
@hamiltondanielb i'd love to check out your fork when you are ready
@hamiltondanielb same here, let me know if you need help or want to maintain/consolidate the fork.
My approach would be to fix 634 code climate issues and rewrite all < es6 code to es6.
https://github.com/madnight/rd3
ok I have vested interest in this project as well. @hamiltondanielb let's see what changes you have made on your fork. I will contribute.
im interested as well
@yang-wei I am interested in maintaining this project as well. If for reasons other than lack of time or personal, what is your reason for no longer maintaining? Are there things to be aware of as maintainer that make this project particularly challenging?
@hamiltondanielb D3v4 compatability would be a nice enhancement.
Has anyone here taken a look at https://github.com/react-d3-library/react-d3-library? There is a compelling demo: http://codepen.io/danieljoonlee/pen/jrPoPE
That library does not appear to be actively maintained either. Perhaps merging the efforts of both libraries would be beneficial.
@AndrewHenderson Main reason for not maintaining is I am not using this library(or React) anymore in work. IMO an active user will be the most suitable candidate for maintainer
@yang-wei OK. I'm going to do some research through this codebase as well as react-d3-library and plan to submit a PR to move this library forward. I figure if you like the work, we can discuss taking over as maintainer. How does that work for you?
In the meantime, I will request the same guidance I requested from react-d3-library. See: issue#52.
I'd like to better understand your code as well as the difficulties your encountered while developing. My understanding is that since d3 takes an imperative approach and React a declarative one, the two projects do not play well together. Has this been your experience?
what's the difference to the react-d3 repository? anyone can show me the improvement to the react-d3?
这个rd3是react-d3的活跃库吗？原来的react-d3已经不再更新了？现在这个也不准备更新了？闹哪样啊？
@windsome I don't know at what point in time this repo forked react-d3, but I believe it was done out of the need for a maintainer. Thus, the project migrated to this repo.
@windsome @AndrewHenderson I do not plan to maintain this library anymore as I am not using it anymore but I will merge pull request from community if there is.
Meanwhile I am willing to transfer it to people who would like to maintain =)
@AndrewHenderson I think we'd better do a search, collect informations about charts library base on react, and do a comparison, then make a choice.
1, reactjs/react-charts, base on canvas
2, highcharts, react-hightcharts
3, react-faux-dom
4, react-d3, d3-react, rd3, react-d3-basic, react-d3-map. some are not active.
compare in terms of code readable, effective ...
@windsome I'm second guessing the benefit of a project such as this one.
What I liked about react-d3-library is how it affords one the ability to use existing D3 code in React components and the DOM differ.
After spending some time using it though, I realized that I was still doing all the D3 DOM interaction which goes against React's declarative DOM state.
I'm not sure how one could write a declarative API for React D3 components unless they were the same set of standard graphs that we see here: https://github.com/yang-wei/rd3/tree/master/src
It seems, if one wants to create a unique graph he's forced to explore D3's imperative API.
I could be wrong. 😐
I actually needed this for my udacity capstone project, so I started one here that uses d3 v4
https://github.com/noahehall/reactjs-d3-universal
@windsome Any conclusions to that?
We are also needing a solution of D3 + React at work. And rather than reiventing the wheel we would very happily contribute to an existing project. It seems there are a ton of implementations of D3 + React to choose from, not sure wich one is the best though.
@albertovilva not get a conclusion. since currently so busy for a project, these stuff things are delayed.
Hi,
I've done a bit of work modifying this library and also working with React Native SVG creation (using both ART and SVG).
I'd be interested in a group chat on Slack or similar to discuss the best use of D3 and React. AS mentioned above the D3 Imperative vs React Declarative is a bit of a tough one.
My current feeling is that D3 should be leveraged for it's calculations only and that React should be in charge of all SVG rendering. Unfortunately there doesn't seem to be a way of handling 'tween' transitions with SVG (although ART does with Morph).
Additionally, if I get any spare time, I wouldn't mind helping out with contributions to the library.
We're about to implement on next project. Interested in looking into building a small roadmap with a few people if anyone is interested.
I have looked into this a little bit and find the approach taken in this library to be better. Curious to heard your thoughts, I'm going to re-implement some d3 on a recent project using this library later this week
i think finding a new maintainer for this project took a little bit to long, so understandably new projects arise and finding a maintainer for this one will become unimportant
I would potentially be interested in maintaining this. I just put in a PR that helps with the PropTypes and CreateClass deprecation warnings: #108
Question is, is anyone still using this at the moment? Speak up if so. Thanks!
I'm currently implementing this module. I had to fork it in order to add some more functionality -- I've added props for axis label color and stroke width.