Make sure we don't lose images again like we did with postimg.org -> postimg.cc
dniku opened this issue · comments
via @yhn112:
Let's choose one of:
- embed images to notebooks
- host images in our repo
- host images on some image hosting
- find all the images on the existing sources.
Currently we use all 4 ways in different places.
Option 1.5: embed images in base64 via html tags. Works with github and colab, but looks a bit ugly when editing markdown cells with it.
IMHO
1., 1.5, - i would recommend switching to this option IF github can render such images. And it would be nice if someone created an instruction for that.
2. this would either require absolute URLs that must be changed on every new branch OR relative urls that are gone in colab
3. for example, imgur seems too large to fail in the conceivable future, but it is still less reliable than (1, 1.5)
4. least reliable option that we used previously to save time. The only justifiable reason to do that would be if we are legally forbidden from copying image to our repo
We can also host images on Github, like PyTorch docs do: pytorch/pytorch#32158 (comment)