yairm210 / Unciv

Open-source Android/Desktop remake of Civ V

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Uniques with `with [50]% chances` isn't translatable.

heipizhu4 opened this issue · comments

Platform
All

Version
4.0.18 (actually the bug exists for a very long time)

Describe the bug
Uniques with with [50]% chances isn't translatable.

To Reproduce
Steps to reproduce the behavior:

  1. Go to any language that has already translated When defeating a [mapUnitFilter] unit, earn [amount] Gold and recruit it and with [amount]% chance (As far as I tested, most 99% translation can test this bug)
  2. Go to civilopedia-nations-The Ottamans
  3. Find this line untranslated:
    image

Expected behavior
It should be translated.

Just had another test, it may be caused by {} inside the unique. Hope to be fixed soon.

Not a bug, they appear in different places.
"with [amount]% chance" is a conditional that can be attached to any unique, so it's translated separately.

Search for "chance" and you'll find it

Working example from Italian:
image

Not a bug, they appear in different places. "with [amount]% chance" is a conditional that can be attached to any unique, so it's translated separately.

Search for "chance" and you'll find it

Working example from Italian: image

Thanks for reply, but how can we explain this?
image
(No more reply from me until tommorow at a time earlier from not, too sleepy)

Good catch, resolved by 46b1516