yairm210 / Unciv

Open-source Android/Desktop remake of Civ V

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Declaration of war bug

lolafur opened this issue · comments

commented

Is there an existing issue for this?

  • I have searched the existing issues

Game Version

4.11.9

Describe the bug

I've had strange experiences in the game where, for example, Kuala Lumpur joined America in the war against Baghdad. And then immediately after this message, America declares war on Kuala Lumpur itself. Looks weird and confusing.
In this case, it wasn’t me who played, the bots played, and I was a spectator. This bug appeared since version 4.11.7

Steps to Reproduce

  1. Go to '...'
  2. Click on '...'
  3. Scroll down to '...'
  4. See error

Screenshots

Screenshot_20240430_162603
Screenshot_20240430_162636

Link to save file

No response

Operating System

Android

Additional Information

No response

Can you give a save file? I'll see when I can look into it.

commented

Can you give a save file? I'll see when I can look into it.

I've never done this before :) How to do this?

The order of events is reversed because thats how we display the notification log.
I think this is the right description of the events:

  • America declares war on KL
  • Baghdad joins America against KL
  • Tripoli joins America against KL

So I must have reversed the Civilization that joins America and the Civ they are fighting against.

Ahhh, I see. I forgot that I have three types of join wars, WarType.DefensivePactWar, WarType.CityStateAllianceWar, WarType.JoinWar.
CityStateAllianceWar and JoinWar should have the same notification types and I grouped CityStateAllianceWar with DefensivePactWar with an if-else statement.

commented

Ahhh, I see. I forgot that I have three types of join wars, WarType.DefensivePactWar, WarType.CityStateAllianceWar, WarType.JoinWar. CityStateAllianceWar and JoinWar should have the same notification types and I grouped CityStateAllianceWar with DefensivePactWar with an if-else statement.

I hope this small flaw will be corrected in the next update :))

I've never done this before :) How to do this?

0 - The pain will go away
1 - If it's a puzzle to you, help us thinking - how to make that easier to learn
2 - (almost tricky) Open an issue from Unciv itself, Unciv helps. If it just crashed. Which you can make it do - Ctrl-Shift (both right side) - Options, Debug tab, big red boom button. If you had a game loaded, the open issue procedure would help get the game data and a lot of usefuly config info over here. Wait - Android - no keys - longpress on the options buttons maybe? Yup.
3 - Save screen, button "copy to clipboard" or similar. There's two - one for running state, one for selected file. Paste here, if possible between two lines containing three backticks each -

```
your paste here

```

(as you can see the backticks are formatting instructions I can't completely circumvent to show how it should look - read that as one quoted block not two)
4 - If the game is too big... Save sceen, to custom location, choose your downloads or documents folder or wherever you can access with the browser, rename to .txt extension (or .json), upload directly (github has a button directly below each post editor box)

I have encountered the same problem, and I see that the civ that joins and the target are in fact switched.

Here's a save file (if it works) - I have Allied with Singapore, so they joined me against Persia, but the notification says Persia joined me against Singapore
https://pastebin.com/Zz2cPPTw

Screenshot_20240505_140035_Unciv

Edit: pastebin seems to hate me because the link isn't working again, here is the file instead
Mongolia - 430 turns.json

The fix is in the next version 4.11.10.