Units without vision cannot be seen when moved into the fog
SeventhM opened this issue · comments
SeventhM commented
Is there an existing issue for this?
- I have searched the existing issues
Game Version
4.11.6
Describe the bug
If a unit has a unique to not see through the fog and moves into the fog, it will no longer be selectable. For a visible example, see ravignir/RekMOD#193. As of writing, I haven't actually tested it myself
Steps to Reproduce
Above
Screenshots
No response
Link to save file
No response
Operating System
Android
Additional Information
No response
SomeTroglodyte commented
Is this as simple as
Index: core/src/com/unciv/logic/map/mapunit/MapUnit.kt
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/core/src/com/unciv/logic/map/mapunit/MapUnit.kt b/core/src/com/unciv/logic/map/mapunit/MapUnit.kt
--- a/core/src/com/unciv/logic/map/mapunit/MapUnit.kt (revision 6b2fe878876b7bc806118cfd48e705100037a9d0)
+++ b/core/src/com/unciv/logic/map/mapunit/MapUnit.kt (date 1713442152722)
@@ -653,7 +653,7 @@
val oldViewableTiles = viewableTiles
viewableTiles = when {
- hasUnique(UniqueType.NoSight) -> hashSetOf()
+ hasUnique(UniqueType.NoSight) -> hashSetOf(getTile()) // 0 sight distance still means we can see the Tile we're in
hasUnique(UniqueType.CanSeeOverObstacles) ->
getTile().getTilesInDistance(getVisibilityRange()).toHashSet() // it's that simple
else -> getTile().getViewableTilesList(getVisibilityRange()).toHashSet()
?
SomeTroglodyte commented
Took me 15min to learn ReKMod and create a save to repro/test:
H4sIAAAAAAAA/+1d23LbOBL9FS1fdrfK9EqkrnlznMnYW3HsjT3jhyk/QCJsYYYiNbw49qT879vgRaZMNgk0qKls7VSqkogk7t3nNIBu4Jv1yKNYhIH17psVpJslj6x37pG1ijhLuHcrkrV8k/CnxHpnjY9Ho+OpdbT7cjFfvLzA1+JR+OIPlkBGsfXul2/yyWe24ZDmPYuWLBIMXhxBPiuZHyTZhr5YCR7nv+DzU0iaROmqyEM+/T3lcXLBAvYgy5JPIu6LB/hg7+FD6Hs8OHkoM3uQdb/i4dbnsu7bUARJ/DGMPkMjfpTvfuQBj5h/GqZBkmViZY8HxXP5YOWzGLKzfmWP7NhnwcPxOXwrizyyHpmfQs7OcPgiG8/jLdQIqrNXqUexSsLoeb/2qQjivScJg/aumH9ynv/mT1s/jLj3hT/kYwIFQAt89syjm+et7M+zdMMCK281DNVicVTp7DORJCLhla7O/o2/8JizaLXmkOQX60IEIniAb04CsWH+4CyNlyzwomf56CESq9RP0ohbd0dWCOJx74dfr2GsghUU4U72B8+K12Hqe5dbHlzJp89XYvWbbB6MJf8/HtltFD6JjUieZZkngRdGEYNSP4cBl738/JwuhReXTxpEIQgTcQ8PXnWqUMJyLAfh/eCXtyN4N1izeLAKN9BFoL9/g7LEKs/Auk5Yci5//KscTRhgtnot4AZE5ST7XQpOIVY1OXl5uXu5k4ObZFIAaf0wr6pM+WS9mx5Z0HIH2iFA5CzHXc5XK4fbk4mzsMcTtrSXw4Vne/eLycId3s/d6UzCSiHFLEnSmMGDexhID2T1VDzuS/c23KZ+WWAmZsnzWzmzlqnwk/fwl8wi64KLEJCLBwnkcMV8lnfBKo0ieFZNfh7/FPPomie5HMM3lZf/SbmUEujQVZgm1l2utwBwu9qUwlwodSlGhc4Lv+izaj9lvybZr1Hxa5b9cotf07130713s4ZcHDlAX8PoN+7dVEssy4C3Ir6MoJ4BKAzbikTqx661AV+B/NyExRspO6kUV/mB9Tr2pzlPQIYN4GUl4fYTv0/2ZGIkAWQZJkm4+SIe1uVLp2gQvAQFTa45D843oESPPBuviuKCcB+nAeDK8a9xGByfsXh9wbY/c6mVDgwsfB7lUlnr4rruX8O3GRQWqm+dgiANVjyDj5c7ObagUD8ACl5+DbjX2F9ZzjsI3qm2GgTfrPngds25L0USeoXnKNwBzH8RaBPM7vABR9Vmgq2MXoHUfw3edzB4AWAO1Og2DDwwUjPEjcTginlMwnb30Oa0IKGL/xQI6E/4WzLoZxbxOGXB3+PBDz7frhkAjIS05aupmqX2xP19NmxQQesDlxXN4RvwRlZ5w7ZXLALBSbLqgazkJhoMZiICwJABjP/gPIYezPAgXrPs/RfAKuhUIDDZoZDLtfgjG6yIeUKi7GgI0C08aXs7YIyveQ6Uo8mOIm9E8Cy7CADe924jWZ8Cul8N959Ly76w2wf/yLhwAEb7P2VteIbbs5E7mw8nw+li6Bbs9EnESUYX2zAWFVK3RxmU2iPJ60sW8xsOuiJkCZcrnlmla0gKA7+zXCsZZClHlJRPGb1k6YfE9Dm92AticjdPPicmH+fJZ8TkOWXbU2LynADtCTF5blzYY2LyeZ7cJSZf5MlJEveUa1ImONT05IROaa/Rkrs7A5qS3HZMNLWq6qQGGKnqqEtVS6B//ywpYWdv3SliAK7E1IzdLvWmZjw2U/yJmeJPzRR/Zqb4czPFXxjqPVl6R2Z67/Sj99TybZxoT0OYl1GFuVmju7MEQy1MI7nwZH0U8VoVPOo6blT7V/Co67hpxi6m46YZjzHtLzNO8icfuTSzswmzdZKEvt+d9QRDBvOsp2aoMcNQo6yZrkDNzXAEl3klu6VeLLUdBS6R7ahyfUZjxM/z5bUOwHFRxKI2dQeCPWNYBR4pUNaBjjhktSmTcnEb4YuERc/5FPibFX4N5DS8ulwVFotbl/VXxazzlkWRCOWktVgzvditzznZdH4TVhYwNsXLC74Jo3KduBmvZ3JB+Qh9+bZnPvCYR0jXXLJYxMpdk6115pN1690Qx30KPOvKrdtlrhkyAQ7XSmiP674SouOQrITo/cEDrmgqFiVeDyVAp/ZCAd/4GGiDpIuC5HUQflWVtk79sdGVF23E7AXC8j0bBQDb+wVk9hBAJQcF4AxWYZzv/KiAnL2zSjOUy3fLWWDWDp4kPu8Tit/UEn37dhxv0sArVsxrYHwmNGiqLkvfI2lV6Op7HEiETZt59MeIxdnqdMvoHVkfYeSktPcFCaNDzXicrhlP71xNpdQxRqlXPvwb7+P5exGHbyz0zj6eYKS7K6BFW3UKmmL03NSSCyY3OvQKaJfaSuY/RSwQ6aby8GQj97gyudApcY4QPVLuCWT2eyq3ja9Fotu6BWIVFByspVZDxEQo8qqKeBrFurnnWlsX+Hru51Emrg2jIKo7+tBx0g0lGWQbg5rVscdd5ktfI1QaSnUDptNOUuoTijHVNwlX+ypz7Psf5OWKjdI8m7TR6WQHDRrz3/fYXTkD92fG3EpPo0PUrv6YYsX0bbzUbYz+bKmKNoI14TfAxoy0hlHH7kMLfrPRVGcohFlPmTSNNfF6bGL5VAq/XnO+pVld7aaDsojuPGLeVEz4j90Q/dZMa60SXm5rGRhwVPw03wJH5VUBHKcsYo/Z8lZfU3JP+ifdMz/marRROgg2kcZMwRZsGNB/p8GDz5WH9D0L4I+uDTRHbMc2WwBTaaRiZyzyvoahR7JqUUuUKG7N9i5qkVLMSdTIo1iMdSvtICtrdXvmgCsyiE2lAy8I1d2KQAvqm1lYBeR7NQTaSVWp5ddJqNf0V0pvp1ICN9fRRJG6TAlq/N1SZ4uQKRV6Ey7ZahXqEjaNeDTxHbEvQRiikHkNpP3aBGu4l++R9Tkj367VnENx1mGqO/8ziGzRzmMkoScQaV3OuyugxRWTrp0gutdIyd/UvT0bdeHbCaYhYNvoRjJF9E35un362kNZ7Yvj1AX+UddOtO4yvqPCegQareP2hURW+d/OrYG2pEoKj05MWxbp1aYpxUbEgcB22sUNeCX3F5arMVyU2p6qMxmBGvrqPWxVUWv2/bqq+HaNrs9Z9Lyd4fqkUQqL9VN+yW80Ry41fsPdT6n+H/gurJqT3SHcS210bqVQt3aCUOKXdjow3Jl1jBmC2rpxhwOTEgcoCdcEQXKFkkjgiJIJ3lV/QhVmCOr139/zduhTKujETzciaNw/dylAXAcWrdoYbdlOzcL1SiTvEW0NI3ls1De0oUa3a+a/Edk2BKfG99ioNa4YIUb2hezyCO2w+XsbVdco1GdMBkkV8MVHhZrvFIEz03xnCHgdCiZxi6fNYqG2rsQiauyvbRj8a6NhQHrIg9MYNTyDGuJjo1YaqUbNUKIYFUNMZxYbbBYaPO6ABxVwoVLGtEPVdUVphii0ToQpWTFnhoo9NVRsw+he2zAqxEa9OUyBwThmXTU93fjAbQ/6rNcs8tc1UuuxkVpPELXWAQWqGsx6UWKyEqJnaygqUWckrZoS18d9FyJX0cJLgWz2YZOraYveU613G10AUUxPStios8iqTpeXuovCArVPsOBaHdWnKu/YSHknRso7RZRXJzIQn+Q3QLFaSPK8CxTIOc8MORs9koPMuYbBnTbqbqlnRRyCUHs8BcDuov126FFeUL70xePbpRtF7Ol7U5RKSW6Hja+CRtRNiUkHnuj2xBRBGLIYzQ313/AsLhs9XcMUP8j6j/p9qeJHLWGbC+CrP4WOgtnYfB3R4rMwink19E0h3KexXMyq6DMCrlZwI5a0uIcUJ2beHaQLsKgzxHGhuTKdcQRNJTsIju0Ma5WSuzyFmgp2EQhs8kT6wFvdGZuyHyMYucteJ7MJApAdXtNNWeXQpOUcpmZzLQwxd26Iueg5aGTMRU/UQHChw7XaacF1Mi4bLitpT9ZooaUtaE9mNMwc04VQbexoNdrQElWWu5Qj6lWzdTrMPJX+0diio84wx/3B2wSBN4No5UbhXRiileFxrXbnAWxq2EbGHcPlcLod2gEaxMXwdhhptXBVdIhgP9iYSWauu2gg8u5Q9loc8u7NwU5TmTSGIetFHmHhgM2do71MO0KBu46w3earTilOB7wS6cHtmHeroDZuSdK82RpOmlD22LPLY6jJsLwwhGXD03TtzlPYumDdbIOkx8MhMbcb5YheY5+5Mc4f5GXYrjU7oiLah7D//hzLb4RAk9bKwe0aRKCFIHFM7OWIlsY6fWJbEQ8+sT9SX2hWzW03QlsqplPKuD+8JOOd4bUBtuGxvy2uo0r2b0ukTqvNpxe6P8MB13A9lxaX3AKMGlFRFa3Zu0BGynl5fYxmHbC1wH7QFd9nJKJr7/bYyMgecxDU6QTEo2bJ7pi04MDXciA0fZexQDuDeA57ZOJJXYVLMtwZ3pZA97THzlcxXBslwxfmPK2FfoZrn/35R9pd62zEfXCSu5UBgow6ZnQq+NOi/CqT0T7Ppx+hHsya+k7WV+o9WDZ2NqaigGPHPxiqe+/72eR5OuZN1VCfK84iXyFMB9sP1LoRhuwgiVG/msKTr78wU1mnS2WVNF77VNZJYwd2ejWTdzZHug7PdRwxMxjo9oKRr7ONxd5recGQddzM3dnGXJy04nHI+oytTmjBAYk+mhVa50448q1WDqbQajQh1/8f2IbvX/bZeDtovM1u1ZR3bQcezMBl3vC/cPM5lQfrXt5fZXe5x+V1nRsR1N448k7Qp6bH2/L/cpuifim8vMN0v7TT8v7TpgKrL0d7Zb55U9zmKsvK0OlDCLnkl28fWTdiIzcpT7PbbbPTpLLbxbPLy+HHBwEzzg18vJKAJnv/S+rzmOc3mf92cflBXmNabNbkbbX24q5lx5/LLvXckeMsZlPb8ZyRPZ4PPXvhzu9tly/vXWfJJxNn+DpwUP0ouUmjQIYI/xchnkn05oAAAA==