yairm210 / Unciv

Open-source Android/Desktop remake of Civ V

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Option window cant be closed by clicking out of it

saud2410 opened this issue · comments

Is there an existing issue for this?

  • I have searched the existing issues

Game Version

4.11.3

Describe the bug

"Never close popups by clicking outside" is revolutionary setting, but option window seems to be the only(afaik) exception. Can't close it when i tap out of it.

Steps to Reproduce

  1. Open Option on main menu or world screen
  2. Check and disable Never close popups by clicking outside setting
  3. Click outside of option popup
  4. See error

Screenshots

image

Link to save file

No response

Operating System

Android

Additional Information

No response

    /** Enables/disables closing by clicking/tapping outside [innerTable].
     *
     *  Automatically set when [addCloseButton] is called but may be changed back or enabled without such a button.
     */
    protected var clickBehindToClose = false

... yes, OptionsPopup does not use the default Popup addCloseButton, so clickBehindToClose defaults to false. I'm pretty sure tat's older than the recent 'move close to a top-right "X"' change... But not 100%.

Good catch.