v1.9.0 creates invalid json by including undefined values

Question

src-code opened this issue 5 years ago · comments

There seems to be a regression in v1.9.0 where objects with undefined values are being included in the json output, which is invalid. For example:

serialize({
  "foobar": undefined
});

Output:

{"foobar":undefined}

This is not valid json, and will fail when run through JSON.parse()

In v1.8.0 this worked correctly with the following output:

{}

Steve Carlson · Answer 1 · Sat Aug 31 2019 09:24:23 GMT+0800 (China Standard Time)

Closing this as I guess it's intentional that this lib creates a superset of json

Jérémie Parker · Answer 2 · Wed Sep 04 2019 19:48:52 GMT+0800 (China Standard Time)

Could you reopen as this looks like a breaking change that might have warranted a major version bump.

Ryuichi Okumura · Answer 3 · Wed Sep 04 2019 20:14:34 GMT+0800 (China Standard Time)

I just released v1.9.1 (includes reverting #54) and v2.0.0 for this issue. Thanks!

Jérémie Parker · Answer 4 · Wed Sep 04 2019 20:23:02 GMT+0800 (China Standard Time)

Thanks for the quick fix @okuryu !