xmtp / xmtp-js

XMTP client SDKs for JavaScript applications.

Home Page:https://xmtp.org/docs

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Bug: Duplicate conversation issues due to case insensitive equality check

neekolas opened this issue · comments

Describe the bug

A developer is experiencing duplicate conversations in v11. We believe it may be related to a case-insensitive check here: https://github.com/xmtp/xmtp-js/blob/main/src/conversations/Conversations.ts#L490

Expected behavior

Conversations are de-duplicated irrespective of wallet address capitalization

Steps to reproduce the bug

  1. Create a conversation with the address using standard checksum formatting
  2. Call client.conversations.newConversation with the same address lowercased
  3. Call client.conversations.list()

One conversation should be returned.