Giters

xmliszt / taboo-ai

Learn English vocabulary while having fun playing a game with intelligent chat AI. Train to use clear English expression and descriptive phrases to trick the AI into saying the target guess word. Taboo AI is both fun and educational, allowing you to gain knowledge, practice english expression, memorise more vocabs, and simply have fun!

Home Page:https://taboo-ai.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Bug: result sharing card floating point error

xmliszt opened this issue · comments

commented

Hey, I think I found the cause of this problem:
There is a totalScore variable in results-share-alert-dialog.tsx and it should probably be rounded when displaying it to the user. If you'd like, you can assign me to this issue and I'll fix it.

telegram-cloud-photo-size-2-5454366938890359785-y

commented

Hey, I think I found the cause of this problem: There is a totalScore variable in results-share-alert-dialog.tsx and it should probably be rounded when displaying it to the user. If you'd like, you can assign me to this issue and I'll fix it.

telegram-cloud-photo-size-2-5454366938890359785-y

Hey @V-Mokhun ! Thanks for spotting the problem and the help! Sure I will assign the issue to you and you can try directly PR to main instead as a quick fix. (I'm currently working on a major feature that merges into preview branch, but no worries, The GitHub actions pipeline will run a preview build when you PR targeting main), you can access the preview build via https://taboo-ai-xmliszt.vercel.app to check your changes. Cheers!

Btw, I think we can stick with 2dp display those score values :)

commented

Hey, I think I finished it, would appreciate it if you take a look. Is there anything else I may help with?

commented

Hey, I think I finished it, would appreciate it if you take a look. Is there anything else I may help with?

Thanks a lot! Looks good :)