editions() returns incorrect isbns when Open Library service is used

Question

editions() returns incorrect isbns when Open Library service is used

acidtv opened this issue 3 years ago · comments

It seems the editions() call with the Open Library service returns ISBNs from other books.

Example:

>>> import isbnlib
>>> isbnlib.meta("9780596007126")
{'ISBN-13': '9780596007126', 'Title': 'Head First Design Patterns', 'Authors': ['Eric Freeman', 'Elisabeth Freeman', 'Kathy Sierra', 'Bert Bates'], 'Publisher': "O'Reilly Media, Inc.", 'Year': '2004', 'Language': 'en'}
>>> isbnlib.meta(isbnlib.editions("9780596007126", "openl")[1])
{'ISBN-13': '9788475335667', 'Title': 'Josafat', 'Authors': ['Prudenci Bertrana'], 'Publisher': '', 'Year': '1999', 'Language': 'ca'}

I'm using isbnlib 3.10.8 with python 3.9.7.

xlcnd · Answer 1 · Thu Oct 28 2021 15:35:54 GMT+0800 (China Standard Time)

There are different 'understandings' of what editions is by the service providers... and I don't have any control of the content returned by the service.

Thanks

Alex Kerkum · Answer 2 · Thu Oct 28 2021 23:29:12 GMT+0800 (China Standard Time)

Yes, but I don't think that is the case here. Looking at the web page for 'Head first design patterns' it shows the correct editions: https://openlibrary.org/books/OL3436354M/Head_First_design_patterns

Digging deeper, it looks like the url to fetch the editions from the Open Library is incorrect. For this example it seems to use http://openlibrary.org/query.json?type=/type/edition&/books/OL3436354M&isbn_13=&isbn_10= to fetch the editions. But that url returns the same results for every /books/* key you put in there.

xlcnd · Answer 3 · Fri Oct 29 2021 02:01:51 GMT+0800 (China Standard Time)

This kind of url is just the Open Library API! I will check what is going on.

xlcnd · Answer 4 · Fri Oct 29 2021 03:52:17 GMT+0800 (China Standard Time)

This API stopped to work! I will implement a new version using the new API (soon).

Alex Kerkum · Answer 5 · Fri Oct 29 2021 15:54:04 GMT+0800 (China Standard Time)

Thank you!

Mek · Answer 6 · Thu Feb 03 2022 14:27:23 GMT+0800 (China Standard Time)

Hi, mek here w/ Open Library. Please let us know if you have questions or need any help w/ Open Library's APIs

https://openlibrary.org/isbn/9780596007126.json is another way to get the json for this item.

xlcnd · Answer 7 · Thu Feb 03 2022 16:32:24 GMT+0800 (China Standard Time)

Thanks mek. Soon, I will try with the new api.

xlcnd · Answer 8 · Sat Feb 05 2022 19:25:33 GMT+0800 (China Standard Time)

For isbnlib, 'editions' is a list of related ISBNs (usually the same book but by another publisher), however after trying with the new API for Open Library, it seems that they don't have the same concept exposed by the API!

Mek · Answer 9 · Sat Feb 05 2022 22:43:38 GMT+0800 (China Standard Time)

For related isbns, you either want the isbns attached to the edition which you can get by adding .json to the edition url e.g. https://openlibrary.org/books/OL25448615M.json

Or you can get the isbns for related editions from the work (which spans editions) using the search API:
https://openlibrary.org/search.json?q=OL25448615M&fields=isbn

The same is true using isbn, e.g. https://openlibrary.org/isbn/9782960133509.json and
https://openlibrary.org/search.json?q=9782960133509&fields=isbn

xlcnd · Answer 10 · Sun Feb 06 2022 01:25:37 GMT+0800 (China Standard Time)

OK, I see! Then it is very easy to fix... it is now on 'dev'.