xlcnd / isbnlib

python library to validate, clean, transform and get metadata of ISBN strings (for devs).

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Migrate imports to collections.abc

dhimmel opened this issue · comments

Got the following warning on our CI build:

  /home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/isbnlib/_imcache.py:4: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
    from collections import MutableMapping

The issue is the following line:

from collections import MutableMapping

Haven't checked whether any other imports in the package need to be moved to collections.abc, but with Python 3.8 just released, these imports will start failing.

commented

Thanks! Already fixed in 'dev' branch.

Still getting warnings when installing the latest version from PyPI. Do you plan to release a version soon that doesn't result in warnings?

commented

As I said in the comment above, this is issue is already fixed in the 'dev' branch. In a few days I will make and release a new version from it.