Support use in Shadow DOM

Question

careless-esper opened this issue 2 years ago · comments

This plugin does not function properly when using with an instance of Embla Carousel contained in a Shadow DOM.

Open https://codesandbox.io/s/sleepy-wing-e8or8g
Use mouse wheel to scroll through top carousel—carousel scrolls as expected
Attempt to use mouse wheel to scroll through bottom carousel—carousel does not scroll properly

In the createRelativeMouseEvent function, when creating the MouseEvent, add composed: true to the dictionary parameter (See https://developer.mozilla.org/en-US/docs/Web/API/Event/composed).

Felix Leupold · Answer 1 · Fri Mar 18 2022 14:58:31 GMT+0800 (China Standard Time)

Thanks for opening the issue, providing a repro and suggesting even a fix. 🤟

I'll try to get this fix in later today/tomorrow.

Felix Leupold · Answer 2 · Sat Mar 19 2022 05:23:39 GMT+0800 (China Standard Time)

@careless-esper Thanks again, for the perfect issue & repro.

I even stole your repro and added it to the demos, hope that's OK 😬

The fix is now available in newly published v2.1.1