exit(1) and fprintf in ILU

Question

exit(1) and fprintf in ILU

LiuZhexuan opened this issue 7 months ago · comments

In ilu_dpivotL, if singularity is detected, exit(1) will be triggered and cause the whole program be terminated. This is inconsistent with what happend in LU. In dpivotL, singularity will only cause LU return with some error info.

The way dpivotL do is more reasonable since superLU user may want to recover from singularity (e.g. add diagnoal matrix to original matix).

X. Sherry Li · Answer 1 · Mon Apr 01 2024 01:59:47 GMT+0800 (China Standard Time)

Fixed this behavior; not to exit(1).

Christoph Grüninger · Answer 2 · Tue Apr 09 2024 21:19:16 GMT+0800 (China Standard Time)

@LiuZhexuan Can you please check the master branch, if this fixes your issues? After you confirm, we can close this.

LiuZhexuan · Answer 3 · Wed Apr 10 2024 10:29:03 GMT+0800 (China Standard Time)

@LiuZhexuan Can you please check the master branch, if this fixes your issues? After you confirm, we can close this.

Thanks, I pulled master branch and confirm this issue has been fixed. Please close.

Christoph Grüninger · Answer 4 · Tue Jul 23 2024 04:38:25 GMT+0800 (China Standard Time)

@xiaoyeli Please close this issue as Liu Zhexiuan confirmed it is fixed.