xen0l / python-asff

Python library to work with Amazon Security Finding Format (ASFF)

Home Page:https://python-asff.readthedocs.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

How to use finding_provider_fields

dnx-seek opened this issue · comments

Hi,

I'm trying to set the original severity using the finding_provider_fields key, but I'm either messing up the format or missing something in general.

Trying something like this:

finding_provider_fields={'severity': 'UNDEFINED'}

But I don't see anything in the resulting findings output.

thanks for putting this lib together, saves a lot of work :D

I have similar with product_fields - I put in all sorts of formats but it never comes through in the final findings output, and I get no warnings or errors.

Hello,

lately I didn't have time to deal do the maintenance, but AWS relased updates to the schema format and those haven't been merged. That's the reason the current version doesn't support those fields. There are PRs to remediate those. I will try to merge them during the weekend.

Could you also unveil your use case for use of this library? Was quite suprised that I found an issue from here :)

Adam

Hi, I ended up not using this and just writing it up myself, it wasn't huge.

My use-case was importing ECR scan results into Security Hub.

@dnx-seek I apologize for bad experience. I was planning to pick this up, but didn't manage to find spare cycles. Though, good news is that I am finishing other things and will be back to this.

Your use case of importing ECR findings to SecurityHub is something I was thinking about in the past as we need it in my current workplace and could demonstrate how to use this library.