xebialabs / overthere

Runs something "Over there"

Home Page:http://www.xebialabs.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Fake error "Connection ... was not closed, closing automatically"

zerikv opened this issue · comments

I noticed an error stack in the console about some connections that was not closed.
This log is produced by the method BaseOverthereConnection#finalize().
I think is not always right for CIFS and SMB connection, because the state connected is set in the constructor of CifsProcessConnection or SmbProcessConnection before calling the method connect().
Thus if the creation of the connection failed (for example a SmbConnection when SMB v2 is disabled) this error is logged but no connection has been actually opened.