xebialabs / overthere

Runs something "Over there"

Home Page:http://www.xebialabs.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add native winrs as an alternative to the Java WinRM implementation

bmoussaud opened this issue · comments

Overthere 1.0 support a java implementation of Winrm.
It should also the winrs options, allowing to call directly the windows binary.
An implementation has been done here for BDF:
https://github.com/xebialabs/bdf-plugin/commit/c2919011ae38f72ddd612175cfbf721ff9a54c60
But there is a lot of code duplication and it will not be easy to switch in deployit for a given host between java implentation and winrs.

What are the advantages of a native WinRS implementation over the Java implementation?

What do you mean by your last sentence? The code duplication can be solved by some good refactoring (like I've already done when integrating the CIFS/WinRM implementation into the CIFS/Telnet implementation) and switching between the WinRS implementation and the Java implementation for a given host should then be as easy as switching between CIFS/WinRM and CIFS/Telnet: by changing an enum.

What are the advantages of a native WinRS implementation over the Java implementation?

Easier to setup on complexe Windows Environment with Domain Controler and Active Directory.
Allow to check the input parameters and later find bugs or improvements in the Java implementation

To be usefull the winrs option should be available in the Windows Hosts, allowing to switch easily from Java Implementation to the WinrsImplementation... as we want to switch from SSH/SFTP to SSH/SCP and SSH/SUDO/SCP...

Closing this in favour of #18, where the pull request and discussion is going on.