Compilation issue for xdp-bench

Question

Compilation issue for xdp-bench

vahsek300501 opened this issue a year ago · comments

I am compliling xdp-tools. First I run ./configure and the I run make. The compilation till xdp-dump happens correctly but after that I starts giving the error for xdp-bench. The following is the error for the same.

"""
In file included from xdp_redirect_basic.c:25:
xdp_redirect_basic.c: In function ‘sample_init’:
../lib/util/xdp_sample.h:72:21: error: implicit declaration of function ‘bpf_program__type’; did you mean ‘bpf_program__size’? [-Werror=implicit-function-declaration]
72 | if (bpf_program__type(skel->progs.name) != BPF_PROG_TYPE_TRACING)
| ^~~~~~~~~~~~~~~~~
../lib/util/xdp_sample.h:111:25: note: in expansion of macro ‘__attach_tp’
111 | __attach_tp(tp_xdp_redirect_map);
| ^~~~~~~~~~~
xdp_redirect_basic.c:31:1: note: in expansion of macro ‘DEFINE_SAMPLE_INIT’
31 | DEFINE_SAMPLE_INIT(xdp_redirect_basic);
| ^~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
In file included from xdp_redirect_cpumap.c:28:
xdp_redirect_cpumap.c: In function ‘sample_init’:
../lib/util/xdp_sample.h:72:21: error: implicit declaration of function ‘bpf_program__type’; did you mean ‘bpf_program__size’? [-Werror=implicit-function-declaration]
72 | if (bpf_program__type(skel->progs.name) != BPF_PROG_TYPE_TRACING)
| ^~~~~~~~~~~~~~~~~
../lib/util/xdp_sample.h:111:25: note: in expansion of macro ‘__attach_tp’
111 | __attach_tp(tp_xdp_redirect_map);
| ^~~~~~~~~~~
xdp_redirect_cpumap.c:55:1: note: in expansion of macro ‘DEFINE_SAMPLE_INIT’
55 | DEFINE_SAMPLE_INIT(xdp_redirect_cpumap);
| ^~~~~~~~~~~~~~~~~~
xdp_redirect_cpumap.c: In function ‘do_redirect_cpumap’:
xdp_redirect_cpumap.c:240:24: error: implicit declaration of function ‘bpf_object__next_program’; did you mean ‘bpf_object__unpin_programs’? [-Werror=implicit-function-declaration]
240 | while ((prog = bpf_object__next_program(skel->obj, prog)) != NULL)
| ^~~~~~~~~~~~~~~~~~~~~~~~
| bpf_object__unpin_programs
xdp_redirect_cpumap.c:240:22: error: assignment to ‘struct bpf_program *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion]
240 | while ((prog = bpf_object__next_program(skel->obj, prog)) != NULL)
| ^
xdp_redirect_cpumap.c:242:21: error: implicit declaration of function ‘bpf_program__expected_attach_type’; did you mean ‘bpf_program__set_expected_attach_type’? [-Werror=implicit-function-declaration]
242 | bpf_program__expected_attach_type(prog) == BPF_XDP)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| bpf_program__set_expected_attach_type
cc1: all warnings being treated as errors
In file included from xdp_redirect_devmap.c:24:
xdp_redirect_devmap.c: In function ‘sample_init’:
../lib/util/xdp_sample.h:72:21: error: implicit declaration of function ‘bpf_program__type’; did you mean ‘bpf_program__size’? [-Werror=implicit-function-declaration]
72 | if (bpf_program__type(skel->progs.name) != BPF_PROG_TYPE_TRACING)
| ^~~~~~~~~~~~~~~~~
../lib/util/xdp_sample.h:111:25: note: in expansion of macro ‘__attach_tp’
111 | __attach_tp(tp_xdp_redirect_map);
| ^~~~~~~~~~~
xdp_redirect_devmap.c:30:1: note: in expansion of macro ‘DEFINE_SAMPLE_INIT’
30 | DEFINE_SAMPLE_INIT(xdp_redirect_devmap);
| ^~~~~~~~~~~~~~~~~~
xdp_redirect_devmap.c: In function ‘do_redirect_devmap’:
xdp_redirect_devmap.c:72:24: error: implicit declaration of function ‘bpf_object__next_program’; did you mean ‘bpf_object__unpin_programs’? [-Werror=implicit-function-declaration]
72 | while ((prog = bpf_object__next_program(skel->obj, prog)) != NULL)
| ^~~~~~~~~~~~~~~~~~~~~~~~
| bpf_object__unpin_programs
xdp_redirect_devmap.c:72:22: error: assignment to ‘struct bpf_program *’ from ‘int’ makes pointer from integer without a cast
-Werror=int-conversion]
72 | while ((prog = bpf_object__next_program(skel->obj, prog)) != NULL)
| ^
xdp_redirect_devmap.c:74:21: error: implicit declaration of function ‘bpf_program__expected_attach_type’; did you mean ‘bpf_program__set_expected_attach_type’? [-Werror=implicit-function-declaration]
74 | bpf_program__expected_attach_type(prog) == BPF_XDP)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| bpf_program__set_expected_attach_type
cc1: all warnings being treated as errors
In file included from xdp_redirect_devmap_multi.c:27:
xdp_redirect_devmap_multi.c: In function ‘sample_init’:
../lib/util/xdp_sample.h:72:21: error: implicit declaration of function ‘bpf_program__type’; did you mean ‘bpf_program__size’? [-Werror=implicit-function-declaration]
72 | if (bpf_program__type(skel->progs.name) != BPF_PROG_TYPE_TRACING)
| ^~~~~~~~~~~~~~~~~
../lib/util/xdp_sample.h:111:25: note: in expansion of macro ‘__attach_tp’
111 | __attach_tp(tp_xdp_redirect_map);
| ^~~~~~~~~~~
xdp_redirect_devmap_multi.c:37:1: note: in expansion of macro ‘DEFINE_SAMPLE_INIT’
37 | DEFINE_SAMPLE_INIT(xdp_redirect_devmap_multi);
| ^~~~~~~~~~~~~~~~~~
xdp_redirect_devmap_multi.c: In function ‘do_redirect_devmap_multi’:
xdp_redirect_devmap_multi.c:108:24: error: implicit declaration of function ‘bpf_object__next_program’; did you mean ‘bpf_object__unpin_programs’? [-Werror=implicit-function-declaration]
108 | while ((prog = bpf_object__next_program(skel->obj, prog)) != NULL)
| ^~~~~~~~~~~~~~~~~~~~~~~~
| bpf_object__unpin_programs
xdp_redirect_devmap_multi.c:108:22: error: assignment to ‘struct bpf_program *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion]
108 | while ((prog = bpf_object__next_program(skel->obj, prog)) != NULL)
| ^
xdp_redirect_devmap_multi.c:110:21: error: implicit declaration of function ‘bpf_program__expected_attach_type’; did you mean
bpf_program__set_expected_attach_type’? [-Werror=implicit-function-declaration]
110 | bpf_program__expected_attach_type(prog) == BPF_XDP)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| bpf_program__set_expected_attach_type
cc1: all warnings being treated as errors
In file included from xdp_basic.c:25:
xdp_basic.c: In function ‘sample_init’:
../lib/util/xdp_sample.h:72:21: error: implicit declaration of function ‘bpf_program__type’; did you mean ‘bpf_program__size’? [-Werror=implicit-function-declaration]
72 | if (bpf_program__type(skel->progs.name) != BPF_PROG_TYPE_TRACING)
| ^~~~~~~~~~~~~~~~~
../lib/util/xdp_sample.h:111:25: note: in expansion of macro ‘__attach_tp’
111 | __attach_tp(tp_xdp_redirect_map);
| ^~~~~~~~~~~
xdp_basic.c:30:1: note: in expansion of macro ‘DEFINE_SAMPLE_INIT’
30 | DEFINE_SAMPLE_INIT(xdp_basic);
| ^~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [../lib/common.mk:107: xdp-bench] Error 1
make: *** [Makefile:34: xdp-bench] Error 2
"""

how to resolve this issue

Toke Høiland-Jørgensen · Answer 1 · Tue May 30 2023 18:28:09 GMT+0800 (China Standard Time)

What's the output of ./configure?

On Tuesday, May 30, 2023, Keshav ***@***.***> wrote: I am compliling xdp-tools. First I run ./configure and the I run make.

The compilation till xdp-dump happens correctly but after that I starts giving the error for xdp-bench. The following is the error for the same.

""" In file included from xdp_redirect_basic.c:25: xdp_redirect_basic.c: In function ‘sample_init’: ../lib/util/xdp_sample.h:72:21: error: implicit declaration of function

‘bpf_program__type’; did you mean ‘bpf_program__size’? [-Werror=implicit-function-declaration]

72 | if (bpf_program__type(skel->progs.name) != BPF_PROG_TYPE_TRACING) | ^~~~~~~~~~~~~~~~~ ../lib/util/xdp_sample.h:111:25: note: in expansion of macro ‘__attach_tp’ 111 | __attach_tp(tp_xdp_redirect_map); | ^~~~~~~~~~~ xdp_redirect_basic.c:31:1: note: in expansion of macro

‘DEFINE_SAMPLE_INIT’

31 | DEFINE_SAMPLE_INIT(xdp_redirect_basic); | ^~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors In file included from xdp_redirect_cpumap.c:28: xdp_redirect_cpumap.c: In function ‘sample_init’: ../lib/util/xdp_sample.h:72:21: error: implicit declaration of function

‘bpf_program__type’; did you mean ‘bpf_program__size’? [-Werror=implicit-function-declaration]

72 | if (bpf_program__type(skel->progs.name) != BPF_PROG_TYPE_TRACING) | ^~~~~~~~~~~~~~~~~ ../lib/util/xdp_sample.h:111:25: note: in expansion of macro ‘__attach_tp’ 111 | __attach_tp(tp_xdp_redirect_map); | ^~~~~~~~~~~ xdp_redirect_cpumap.c:55:1: note: in expansion of macro

‘DEFINE_SAMPLE_INIT’

55 | DEFINE_SAMPLE_INIT(xdp_redirect_cpumap); | ^~~~~~~~~~~~~~~~~~ xdp_redirect_cpumap.c: In function ‘do_redirect_cpumap’: xdp_redirect_cpumap.c:240:24: error: implicit declaration of function

‘bpf_object__next_program’; did you mean ‘bpf_object__unpin_programs’? [-Werror=implicit-function-declaration]

240 | while ((prog = bpf_object__next_program(skel->obj, prog)) != NULL) | ^~~~~~~~~~~~~~~~~~~~~~~~ | bpf_object__unpin_programs xdp_redirect_cpumap.c:240:22: error: assignment to ‘struct bpf_program *’

from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion]

240 | while ((prog = bpf_object__next_program(skel->obj, prog)) != NULL) | ^ xdp_redirect_cpumap.c:242:21: error: implicit declaration of function

‘bpf_program__expected_attach_type’; did you mean ‘bpf_program__set_expected_attach_type’? [-Werror=implicit-function-declaration]

242 | bpf_program__expected_attach_type(prog) == BPF_XDP) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | bpf_program__set_expected_attach_type cc1: all warnings being treated as errors In file included from xdp_redirect_devmap.c:24: xdp_redirect_devmap.c: In function ‘sample_init’: ../lib/util/xdp_sample.h:72:21: error: implicit declaration of function

‘bpf_program__type’; did you mean ‘bpf_program__size’? [-Werror=implicit-function-declaration]

72 | if (bpf_program__type(skel->progs.name) != BPF_PROG_TYPE_TRACING) | ^~~~~~~~~~~~~~~~~ ../lib/util/xdp_sample.h:111:25: note: in expansion of macro ‘__attach_tp’ 111 | __attach_tp(tp_xdp_redirect_map); | ^~~~~~~~~~~ xdp_redirect_devmap.c:30:1: note: in expansion of macro

‘DEFINE_SAMPLE_INIT’

30 | DEFINE_SAMPLE_INIT(xdp_redirect_devmap); | ^~~~~~~~~~~~~~~~~~ xdp_redirect_devmap.c: In function ‘do_redirect_devmap’: xdp_redirect_devmap.c:72:24: error: implicit declaration of function

‘bpf_object__next_program’; did you mean ‘bpf_object__unpin_programs’? [-Werror=implicit-function-declaration]

72 | while ((prog = bpf_object__next_program(skel->obj, prog)) != NULL) | ^~~~~~~~~~~~~~~~~~~~~~~~ | bpf_object__unpin_programs xdp_redirect_devmap.c:72:22: error: assignment to ‘struct bpf_program *’

from ‘int’ makes pointer from integer without a cast

-Werror=int-conversion] 72 | while ((prog = bpf_object__next_program(skel->obj, prog)) != NULL) | ^ xdp_redirect_devmap.c:74:21: error: implicit declaration of function

‘bpf_program__expected_attach_type’; did you mean ‘bpf_program__set_expected_attach_type’? [-Werror=implicit-function-declaration]

74 | bpf_program__expected_attach_type(prog) == BPF_XDP) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | bpf_program__set_expected_attach_type cc1: all warnings being treated as errors In file included from xdp_redirect_devmap_multi.c:27: xdp_redirect_devmap_multi.c: In function ‘sample_init’: ../lib/util/xdp_sample.h:72:21: error: implicit declaration of function

‘bpf_program__type’; did you mean ‘bpf_program__size’? [-Werror=implicit-function-declaration]

72 | if (bpf_program__type(skel->progs.name) != BPF_PROG_TYPE_TRACING) | ^~~~~~~~~~~~~~~~~ ../lib/util/xdp_sample.h:111:25: note: in expansion of macro ‘__attach_tp’ 111 | __attach_tp(tp_xdp_redirect_map); | ^~~~~~~~~~~ xdp_redirect_devmap_multi.c:37:1: note: in expansion of macro

‘DEFINE_SAMPLE_INIT’

37 | DEFINE_SAMPLE_INIT(xdp_redirect_devmap_multi); | ^~~~~~~~~~~~~~~~~~ xdp_redirect_devmap_multi.c: In function ‘do_redirect_devmap_multi’: xdp_redirect_devmap_multi.c:108:24: error: implicit declaration of

function ‘bpf_object__next_program’; did you mean ‘bpf_object__unpin_programs’? [-Werror=implicit-function-declaration]

108 | while ((prog = bpf_object__next_program(skel->obj, prog)) != NULL) | ^~~~~~~~~~~~~~~~~~~~~~~~ | bpf_object__unpin_programs xdp_redirect_devmap_multi.c:108:22: error: assignment to ‘struct

bpf_program *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion]

108 | while ((prog = bpf_object__next_program(skel->obj, prog)) != NULL) | ^ xdp_redirect_devmap_multi.c:110:21: error: implicit declaration of

function ‘bpf_program__expected_attach_type’; did you mean

bpf_program__set_expected_attach_type’?

[-Werror=implicit-function-declaration]

110 | bpf_program__expected_attach_type(prog) == BPF_XDP) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | bpf_program__set_expected_attach_type cc1: all warnings being treated as errors In file included from xdp_basic.c:25: xdp_basic.c: In function ‘sample_init’: ../lib/util/xdp_sample.h:72:21: error: implicit declaration of function

‘bpf_program__type’; did you mean ‘bpf_program__size’? [-Werror=implicit-function-declaration]

72 | if (bpf_program__type(skel->progs.name) != BPF_PROG_TYPE_TRACING) | ^~~~~~~~~~~~~~~~~ ../lib/util/xdp_sample.h:111:25: note: in expansion of macro ‘__attach_tp’ 111 | __attach_tp(tp_xdp_redirect_map); | ^~~~~~~~~~~ xdp_basic.c:30:1: note: in expansion of macro ‘DEFINE_SAMPLE_INIT’ 30 | DEFINE_SAMPLE_INIT(xdp_basic); | ^~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors make[1]: *** [../lib/common.mk:107: xdp-bench] Error 1 make: *** [Makefile:34: xdp-bench] Error 2 """ how to resolve this issue — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message

ID: ***@***.***>

Keshav · Answer 2 · Tue May 30 2023 18:29:37 GMT+0800 (China Standard Time)

Found clang binary 'clang' with version 14 (from 'Ubuntu clang version 14.0.0-1ubuntu1')
using /usr/lib/linux-tools/5.19.0-42-generic/bpftool v7.0.0
libbpf support: system v0.5.0
perf_buffer__consume support: yes
btf__load_from_kernel_by_id support: yes
btf__type_cnt support: no
bpf_object__next_map support: no
bpf_object__next_program support: no
bpf_program__insn_cnt support: no
bpf_program__type support: no
bpf_program__flags support: no
bpf_map_create support: no
perf_buffer__new_raw support: no
bpf_xdp_attach support: no
bpf_map__set_autocreate support: no
bpf_prog_test_run_opts support: no
secure_getenv support: yes

This is the output for ./configure

Toke Høiland-Jørgensen · Answer 3 · Wed May 31 2023 16:38:26 GMT+0800 (China Standard Time)

Please try #329

Keshav · Answer 4 · Thu Jun 01 2023 01:21:06 GMT+0800 (China Standard Time)

This stills gives an error in compilation of util. Attaching the screenshot of error and configure command

Toke Høiland-Jørgensen · Answer 5 · Thu Jun 01 2023 01:51:08 GMT+0800 (China Standard Time)

Alright, added another commit to #329 that hopefully fixes those as well. Please try that :)

Keshav · Answer 6 · Thu Jun 01 2023 01:57:12 GMT+0800 (China Standard Time)

Sorry I am bit new to XDP. But this is another error. I don't know how to resolve this also. Please help :(

Toke Høiland-Jørgensen · Answer 7 · Thu Jun 01 2023 02:07:33 GMT+0800 (China Standard Time)

Right, that's another bug unearthed by the previous changes. Added yet another commit to fix that, please try again :)

Keshav · Answer 8 · Thu Jun 01 2023 02:16:15 GMT+0800 (China Standard Time)

All the compilations were successfull except trafficgen compilation. The error was not reported in red but this is an issue

Toke Høiland-Jørgensen · Answer 9 · Thu Jun 01 2023 02:37:53 GMT+0800 (China Standard Time)

Alright, pushed another commit to hopefully take care of that one as well :)

Keshav · Answer 10 · Thu Jun 01 2023 02:42:48 GMT+0800 (China Standard Time)

Yes this commit worked. I was successfully able to compile the code. Thanks a lot for help 👍 :)

Toke Høiland-Jørgensen · Answer 11 · Thu Jun 01 2023 02:57:56 GMT+0800 (China Standard Time)

Awesome! Thank you for the report and for your help with debugging! :)