Potential issue with non-loading thumbnails
wutschel opened this issue · comments
Via TestFlight an issue with non-loading posters / banners was reported.
Examples:
When I looked at the usual images which are loaded, it became obvious that usually these images are the "poster" of additional "art". A while back remote apps were required to update their code to not use "thumbnail", but "poster" (if available). If this is not done, there are wrong images shown -- see #107 for the change and the related bug reports.
Problem is, Kodi API provides URLs to image providers like fanart.tv as "poster". These are not locally cached images on the Kodi server. So, in case you need to re-load such images, they might have been removed from the image provider's server. I guess only re-scraping can resolve this problem.
@howie-f, you think this sounds like the underlying root cause? Could you e.g. use another remote (e.g. WebUI) to double check?
I guess only re-scraping can resolve this problem.
hm, i don't think so. did some quick testing with the following results:
- Start Nexus => Clear cache of IOS Remote and restart it => All posters shown
- Start Omega = Clear cache Remote and restart => missing posters, album covers, tvshow banners etc.
so honestly i doubt it is an issue of IOS Remote...
there were some pullrequests by @rmrector recently merged regarding [guilib][vfs][imagecache] Load video thumbnail images into texture cache example xbmc/xbmc#23134 ff.
could be they changed behaviour but i'm not sure yet
Thanks for looking into this. So, we have an unexpected change of behavior between Nexus and Omega which results in the issue you are experiencing.
Independent of this, the problem of potentially outdated URLs to poster images will be a problem as well. I am sure it would be conceptually desired to show the same thumbnails on Kodi and the remotes. This would only be guaranteed, if Kodi caches such images and then provides a link to this cached image, instead of pointing to an URL.
See the Kodi wiki on how to fetch images "through" Kodi in a way that shares the image cache. Probably that's already done, or the remote would fail to show some or all artwork stored locally.
https://kodi.wiki/view/Artwork/Accessing_with_skins_and_JSON-RPC#Kodi-encoded_URL
Yes, the App does it like described in the Wiki.
@howie-f, just to narrow down further.
- Can you try to use the WebUI?
- I would expect the issue to show up here as well.
- And if this should not show the problem can you use the official Remote App release 1.12.1 (from AppStore)?
- This would fall back to the former version of SDWebImage
@wutschel
exactly
- WebUi (Chorus2) works fine with Nexus — but does not with Omega (missing art)
- iOS Remote v1.12.1 (3752) works correctly with Nexus — has the same issues with Omega
Thanks, @howie-f. So this is clearly a problem of Omega and not of any of the remotes. Which leads us to either
- problem with image cache, or
- problem with Kodi providing access to image cache, or
- mismatch between image cache and what is provided via API
Are you able to pull WebUI traces which show working and non-working loading attempts?
Are you able to pull WebUI traces which show working and non-working loading attempts?
no idea, sorry. i think the json calls from remotes haven‘t changed so this is likely not what we want
going to bisect the commit that introduced this „regression“
no idea, sorry. i think the json calls from remotes haven‘t changed so this is likely not what we want
No, not the JSON calls sent, but the responses could show mal-formatted image paths. Recently someone also shared a webUI log which showed non-loading image URLs for TV programs (see xbmc/xbmc#23529). I am not sure how to pull these logs though.
But bisecting will of course also directly point to the change which introduced this regression. Looking forward to see which change caused this.
I think I found a fix. Tough to find a clear reproduction for the issue, it seemed to happen slowly over time.
Tough to find a clear reproduction for the issue
yes
with your pr it is fixed now, but Textures13.db and Thumbnails folder needed to be cleared o see the effect
Pull Request got merged to Kodi.