Giters

xavier / huex

Elixir client for Philips Hue connected light bulbs

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add support for groups?

tehviking opened this issue · comments

commented

First off, thanks for the awesome project, I was doing manual API calls in my Slack bot project but I'm now rewriting it to use this instead, it's really well written from what I can tell, and was easy to extend.

I created a fork that adds support for fetching and changing stuff for groups in the grossest and jankiest way possible.

It's my first elixir project so it's not something I'd issue a pull request for, but if you have any thoughts or pointers as to how to re-architect, I'm open to suggestions.

https://github.com/tehviking/huex

Thanks!

commented

Thanks for the feedback, I just came back from holidays and I'll have a look at it asap!

commented

Your code is fine and has been merged. Thanks! 👍

I may do some refactoring later to extract a few redundant payload building code but it's definitely Good Enough for a release. The new hex package has been published, feel free to upgrade your dependencies.