Odd behavior when performing config:push relating to newlines

Question

Odd behavior when performing config:push relating to newlines

ifd3f opened this issue 7 years ago · comments

Something weird happens with newlines when I push these .env files.

DISCORDTOKEN=foo
LOGLEVEL=20
HSAPI=bar

When I push this, the DISCORDTOKEN and LOGLEVEL lines will not be parsed correctly, but HSAPI will.

DISCORDTOKEN=foo
HSAPI=bar
LOGLEVEL=20

When I push this, the DISCORDTOKEN and HSAPI lines will not be parsed correctly, but LOGLEVEL will.

DISCORDTOKEN=foo
LOGLEVEL=20
HSAPI=bar

If I add a trailing newline, HSAPI also does not get parsed.

David Brownman · Answer 1 · Mon Feb 27 2017 12:22:04 GMT+0800 (China Standard Time)

Interesting! The file reader splits by newline so it's weird that it parses worse when there's an extra newline. Would you mind emailing me (or providing a link to) the file itself? Secrets redacted of course, but it would be useful to test against. ~DavidB [davidbrownman.com] c: 303.819.0850

…

On February 26, 2017 at 7:26:41 PM, Max ***@***.***) wrote: Something weird happens with newlines when I push these .env files. DISCORDTOKEN=foo LOGLEVEL=20 HSAPI=bar When I push this, the DISCORDTOKEN and LOGLEVEL lines will not be parsed correctly, but HSAPI will. DISCORDTOKEN=foo HSAPI=bar LOGLEVEL=20 When I push this, the DISCORDTOKEN and HSAPI lines will not be parsed correctly, but LOGLEVEL will. DISCORDTOKEN=foo LOGLEVEL=20 HSAPI=bar If I add a trailing newline, HSAPI also does not get parsed. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#11>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABLMP7Az6nLYq7nr29NwlMPoJwBJ9OKuks5rgkJxgaJpZM4MMp7D> .

David Brownman · Answer 2 · Thu Mar 02 2017 13:03:40 GMT+0800 (China Standard Time)

@Plenglin All right, sorry for the delay here! Your problem is twofold.

The file you sent had windows-style line breaks (\r\n) instead of unix (\n), so that's why there was some weirdness with the newlines. I'll release a fix to handle that and you should be ok.

Secondly, your hs-api variable has an invalid name. Since heroku runs on linux, variable names must conform to those valid in unix. I'd recommend hs_api instead. I'll make a note in the readme that clarifies this.

David Brownman · Answer 3 · Fri Mar 03 2017 03:01:22 GMT+0800 (China Standard Time)

Release is out, should be all set here. Thanks for the report!