Unsure cosmetic filtering is even working
chris122380 opened this issue · comments
I am unsure what websites this cosmetic filtering is supposed to be working on. I have followed the directions for installing the plugin. I have also added the extended filter (https://github.com/xarantolus/filtrite/releases/latest/download/bromite-extended.dat). I am still getting white space on many webpages.
Example 1: KSL news (KSL.com)
Example 2: celebwell.com
Bromite 102.0.5005.96
Oxygen OS 12 (OnePlus 9 Pro)
So for the first page there are filters available, but they are more advanced; the script currently doesn't support them:
ksl.com#?#.queue:-abp-has(.sponsored)
Supporting this type of selector would probably be quite some work and have quite a performance impact; I'd prefer to keep the logic simple.
For the second one there just aren't any filters in the lists that I added.
In general the script is really basic, so it tends to only work on pages with rather basic blockable elements (It does remove a lot of full-screen overlays on different pages though, which is nice).
So for the first page there are filters available, but they are more advanced; the script currently doesn't support them:
ksl.com#?#.queue:-abp-has(.sponsored)Supporting this type of selector would probably be quite some work and have quite a performance impact; I'd prefer to keep the logic simple.
For the second one there just aren't any filters in the lists that I added.
In general the script is really basic, so it tends to only work on pages with rather basic blockable elements (It does remove a lot of full-screen overlays on different pages though, which is nice).
This is why I don't tend to use Bromite. It has to much white space and/or cosmetic issue not seen with other browsers.