[Installer] - Better fail checks

Question

[Installer] - Better fail checks

xan1242 opened this issue 2 years ago · comments

Lovro Pleše commented 2 years ago

Installer does NOT work under Wine/Proton because the work directory is wrong.

Secondly, the installer says it succeeded even though it clearly failed because of this.

Lovro Pleše · Answer 1 · Mon Aug 22 2022 01:49:38 GMT+0800 (China Standard Time)

So this actually seems to be an issue with Wine's command interpreter.

For a 'for' loop, it doesn't accept paths in quotation marks as an argument and it fails instantly. On Windows this works just fine.

for %%f in ("InteractiveMusic/*.asf") won't do anything

for %%f in (InteractiveMusic/*.asf) will work

This is very janky anyways and it needs a better way to call the process (instead of issuing the system command) but I guess this will have to do for now.

(I guess this will have to be noted in a Wine bug report if it hadn't been done already)

Lovro Pleše · Answer 2 · Mon Aug 22 2022 05:11:35 GMT+0800 (China Standard Time)

For MW it was fixed in d22a65e

Carbon is next...

Lovro Pleše · Answer 3 · Mon Aug 22 2022 07:10:40 GMT+0800 (China Standard Time)

Carbon issues fixed in b7d8535

Next would be to implement better error checks.

Lovro Pleše · Answer 4 · Mon Dec 12 2022 09:59:14 GMT+0800 (China Standard Time)

Halting this issue until this is resolved: #15

Considering the removal of interactive music means removal of the installer.