Feature: Chromatic 'scale' for Chords
riban-bw opened this issue · comments
It would be advantageous to allow the chord plugin to work for any note, not just those defined in the configured scales. This could be done by adding another scale which has all 12 notes.
It may be advantageous to allow custom scale to be defined, e.g. a Boolean parameter for each note to allow / inhibit it within the scale. This might be just exposing existing internal parameter/s which are set by the scale selection.
This might be just exposing existing internal parameter/s which are set by the scale selection.
That's seems reasonable. So instead of a static array, filter_midichord_halftoneoffset () looks up data from 12 control inputs. The root-note can probably go away, as can filter_midichord_isonscale.
The hard part will be to keep track of active notes when a user changes the scale, or when the scale is automated.
However I think it would be preferable to create a new plugin (based on chords) instead of modifying the existing one.
(Changing control parameters of plugins that are used and potentially automated in existing sessions is bad practice)