x1ddos / simpleauth

Simple authentication for Python on Google App Engine supporting OAuth 2.0, OAuth 1.0(a) and OpenID

Home Page:https://simpleauth.appspot.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Possibly spare 1 URL fetch call during _on_signin

x1ddos opened this issue · comments

commented

I'm thinking to make _get_<provider>_user_info() call optional. This way one could spare a URL fetch call when existing users sign in as their profile data have probably been already stored during some previous logins.

Additionally, this could make it easier for a backend profile fetch instead of doing it during the user facing request.

Would this be a good idea?

@crhym3 This sounds like a very good idea.

commented

I'll try to come up with a CL during this week and post it here for a review.