Throwing a warning in the admin when Show Avatars is disabled.

Question

Throwing a warning in the admin when Show Avatars is disabled.

Japh opened this issue 10 years ago · comments

Just updated my sites to Stream 1.4.4 and noticed that when Show Avatars is disabled (not selected) in Settings > Discussion, the following warning is displayed, twice for each "author", at the top of the Stream admin page:

Warning: assert(): Assertion failed in /home/[...]/public_html/wp-content/plugins/stream/includes/class-wp-stream-author.php on line 119

Doesn't break the site, but it definitely doesn't look good. Thought you'd want to know...

Originally reported on the WordPress.org forums

Shady Sharaf · Answer 1 · Sat May 10 2014 18:54:45 GMT+0800 (China Standard Time)

I'm on it.

Japh · Answer 2 · Sat May 10 2014 19:00:46 GMT+0800 (China Standard Time)

No, I am :)

Shady Sharaf · Answer 3 · Sat May 10 2014 19:51:34 GMT+0800 (China Standard Time)

@Japh wp-cli avatar still shows while the 'show_avatars' setting is disabled, we might need to address this here as well.

Weston Ruter · Answer 4 · Sat May 10 2014 20:44:42 GMT+0800 (China Standard Time)

Oh yeah. The WP_Stream_Author class manually supplies an image for the
system user.

Japh · Answer 5 · Sat May 10 2014 21:28:50 GMT+0800 (China Standard Time)

Thanks for the heads up, @shadyvb. Fixed that now.

Shady Sharaf · Answer 6 · Sat May 10 2014 23:56:02 GMT+0800 (China Standard Time)

Cool, @fjarrett This needs to be issued as a hotfix to prevent notices on installations with show_avatars=false, probably lots of them are there.