xwp / stream

🗄️ Stream plugin for WordPress

Home Page:https://wordpress.org/plugins/stream/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

AJAX loading for user filter in list table

shadyvb opened this issue · comments

Load users via AJAX, to accommodate for sites with thousands of users. Only use AJAX if user count is more than 50 user.

Using Select2 is preferred, due to the support/activity compared to chosen, and the built-in AJAX of course.

Closing issue, since user trigger has been AJAXified and pushed to master. Other bugs/fixes should be reported to a new issue.

@shadyvb I saw the word "trigger" and got confused with that other secret project we've been working on 😉

😳 Oooh! Sorry!
/me Reopening the issue.

@shadyvb @fjarrett Guys, how about limiting that dropdown to users that wrote at least one post, in addition of using Ajax here?

@powelski Well just because they haven't written a post doesn't mean they haven't performed other actions, like updating a widget or menu, for instance. So what we want to do is only load in users that have authored Stream records.

@fjarrett That's true - at the time of writing I was focused on filtering posts, because of the "authors" word.

Closing after PR merge.

Ajax loading is not working in Author filter, its showing empty filter and list page also taking too much time to load.

stream-author-filter-issue

FYI : Site have 10K+ users

Thanks for checking this @faishal, I'm reopening the issue now.

Wondering if @powelski has noticed reopening of the issue.

@powelski I'm taking over this one, just in case you haven't noticed it.
/cc @fjarrett

Fixed by #428