xwp / stream

🗄️ Stream plugin for WordPress

Home Page:https://wordpress.org/plugins/stream/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Autocomplete not working correctly in Exclude IP Addressees field

fjarrett opened this issue · comments

The autocomplete functionality does not appear to be working in the Stream > Settings > Exclude > IP Addresses field.

screen shot 2014-03-12 at 6 12 06 pm

You are forced to type the entire IP before it will appear, so I think the period delimiters are causing a problem.

screen shot 2014-03-12 at 6 13 40 pm

@fjarrett This behavior doesn't have anything to do with period delimiters. It occurs, because IP regex is being checked while you type and the suggestion appears once IP address is valid. What is expected here:

  1. Should the list of results be prefilled with IP addresses of existing logs (sorted by the number of logs perhaps)

or

  1. There should be no suggestions at all?

@powelski The expected behavior would be:

  1. The results would be preloaded with all the IP addresses previously logged, sorted numerically.
  2. As you type, the results would narrow.
  3. You should be able to enter any IP, not just those that have been logged before. When this is the case, then the IP should be validated with regex before it can be added.

@fjarrett Does numerically mean same thing as one mentioned by me before (the number of logs)?

@powelski No, it means by value of the first section of the IP.

50.xxx
192.xxx
207.xxx

@powelski FYI issues will close automatically once the PR is merged into master. So the issue will remain open until it has been included in a public release.