wwwtyro / cryptico

An easy-to-use encryption system utilizing RSA and AES for javascript.

Home Page:http://wwwtyro.github.com/cryptico

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Protocol issues

owlstead opened this issue · comments

There seem to be some issues with this protocol.

You seem to sign before encryption, which makes you vulnerable to padding oracle attacks.

Furthermore, you send you public key with the signed message. But this makes no sense, as the receiver has no method of trusting the public key.

Other than that, please be aware that performing encryption/signing in JavaScript may not make sense as the JavaScript code itself cannot be trusted. So you need to at least require the use of TLS/SSL.

In your signing paragraph, you say that you attach information to the ciphertext but you end up adding information to the plaintext.

That said, the documentation of your project is very readable.