For what use dosage comic description?
MarkusHackspacher opened this issue · comments
Like in https://github.com/wummel/dosage/blob/master/dosagelib/plugins/w.py#L69
description = u'We Can Sleep Tomorrow - Life does not take bathroom breaks. A webcomic that updates Mondays and Fridays'
PEP 8
First,I have look in the dosage code for style errors of PEP 8 -- Style Guide for Python Code http://legacy.python.org/dev/peps/pep-0008/
I have check die code with the pep8 tool. https://pypi.python.org/pypi/pep8
maximum of 79 characters
An the pep8 limit all lines to a maximum of 79 characters. For example of first line: https://github.com/MarkusHackspacher/dosage/blob/master/dosagelib/plugins/w.py#L87-L88
description = (u'We Can Sleep Tomorrow - Life does not take bathroom '
'breaks. A webcomic that updates Mondays and Fridays')
Set string in () and set '' for break line. I have make some changes in the code and send a pull request when I'm finished. https://github.com/MarkusHackspacher/dosage
update description
All that are not the problem. I see in the smackjeeves.py is the code generate by scripts/update_description.py. And in the file https://github.com/wummel/dosage/blob/master/scripts/smackjeeves.py#L343-L344 write it back in the file:
fp.write(u"%sadd(%r, %r, %r, %s, %s)\n" % ( prefix, str(truncate_name(name)), str(url), desc, adult, bounce
If not need so must description, change desc to desc[:10] or make two line with desc[:60]. or longer?
To make it right, should I know, how long the description should be?
The description is used in the comic list. The idea is to have an online list of all supported comics. Most of the descriptions are automatically generated. Otherwise it would be a lot of work to add and update them, which I just don't have the time for.
Regarding pep8: I don't enforce these formatting rules in the code, so style-changing patches are not necessary.