VM_Create on UI failed (Recursive error)

[Victor Roemer]

A situation exists where creating the uivm results in an ERR_DROP recursively.

Looks like I introduced this with my work-around for initial server connect download crash; on failure to load the ui.qvm set cls.uiStarted = false.

• CL_InitUI(..)
  • cls.uiStarted = qfalse ✋
  • Com_Error( ERR_DROP )
    • CL_FlushMemory()
      • CL_StartHunkUsers()
        • if cls.uiStarted == false ⬇️
          • CL_InitUI()
            • Com_Error( ERR_DROP ) 💥

Interestingly this only happened when the MOD DIRectory EXISTS and is MISSING correct VM's.

[Victor Roemer]

Reported the issue upstream ioquake3/ioq3 #214