Unit Tests Without Assertions?

Question

Unit Tests Without Assertions?

jamiejackson opened this issue 9 years ago · comments

I'm confused about the unit tests without assertions. I took a quick stab at writing some assertions, but since all of the (new) assertions fail, something's wrong with the code or (very likely) my assumptions.

jamiejackson@fb34c7b

Enrico Maria Crisostomo · Answer 1 · Tue Jul 21 2015 06:27:50 GMT+0800 (China Standard Time)

Hi @jamiejackson,

Yes, you're right: those assertions fail. The only "proper" unit test is rfc6238TestVectors, a method that tests the TOTP generator against the test vectors specified in RFC 6238. The other methods are legacy and utility methods that are there for (my) convenience. Some of them could be cleaned up and refactored into proper unit tests, while others should probably be dropped altogether.