[bug] useFormState callback cache causes stale closures

Question

[bug] useFormState callback cache causes stale closures

derrickbeining opened this issue 5 years ago · comments

The implementation of useFormState is problematic because it caches callback functions passed to inputs.text et. al. This causes functions like onChange, validate, and onBlur to run with stale closures, namely, the closure with which they are initialised. This can be fixed simply by removing const callbacks = useCache(); from the implementation.

Derrick Beining · Answer 1 · Sun May 12 2019 10:06:33 GMT+0800 (China Standard Time)

See PR at #76

Troy Goode · Answer 2 · Thu Jul 11 2019 07:44:17 GMT+0800 (China Standard Time)

Can you re-open this? That PR was reverted and this stale closure issue is making react-use-form-state unusable for me. We really need to be able to pass in an array of dependencies ala native hooks.

Mads Hargreave · Answer 3 · Thu May 14 2020 21:16:14 GMT+0800 (China Standard Time)

Any news on this?

Waseem Dahman · Answer 4 · Mon May 18 2020 04:14:20 GMT+0800 (China Standard Time)

Fix is on the way!

We really need to be able to pass in an array of dependencies ala native hooks.

and that shouldn't be needed! 😄

Waseem Dahman · Answer 5 · Sun May 24 2020 01:21:20 GMT+0800 (China Standard Time)

The latest release 0.13.1 addresses the stale closures problem. This is no longer be an issue!

Callbacks were originally cached for performance reasons (we don't want to re-render the entire form inputs any time the form state changes). This remains true with the latest release.

Demo (0.13.0): https://xii57.csb.app/
Demo (0.13.1): https://6evzz.csb.app/