Allow modification of persisted queries but not the query string itself
ChrisWiegman opened this issue · comments
GitHub
Description
Currently, one can modify a persisted query and change both the meta data as well as the query string itself. A query shouldn’t be able to change. Enforce that users can change the meta data but not modify the query string.
Acceptance Criteria
...
Technical Details
...
References
...
Open Questions
What is the editor behavior?
What is the mutation behavior?
If the query is ‘published’ and content is different on save, do not save the content change? Instead return an error. In admin editor this shows at the top of page. For mutation, this would be a return error.
Suggest to the user in the error message to convert the published post to draft to edit it and save? Then publish again? This would result in different md5 hash id to the query string. The other md5 hash of the query string would be removed, ie, queries for that query_id would fail.
What about a ‘clone’ or ‘save as new’ ability? When see error message in admin editor, there is a check box to ‘save as new’ on publish. If selected, the old/existing post is saved to a new post type? Then the save of the existing query is processed with the new content string.
PR #255