todo - trailing underscores

Question

barncastle opened this issue 6 years ago · comments

Fields in the following have trailing underscores

+1 🔥

Martin Benjamins · Answer 1 · Mon Mar 19 2018 23:37:46 GMT+0800 (China Standard Time)

Are those from official names? Eww.

barncastle · Answer 2 · Mon Mar 19 2018 23:42:45 GMT+0800 (China Standard Time)

I was dubious but apparently so - just checked renderservice...
Personal preference is to burn them with fire but thats up for debate!

Bernd Lörwald · Answer 3 · Tue Mar 20 2018 04:14:36 GMT+0800 (China Standard Time)

Iirc those are fields that are union’d to a real type, C2Vector and md5digest.

Since we don’t do that, i think I’m fine with just removing the character and keeping it as verified.

Then again, I don’t see this as a big issue actually needing a change either.

Martin Benjamins · Answer 4 · Tue Mar 20 2018 20:35:46 GMT+0800 (China Standard Time)

Am fine with fixing these for purely aesthetic reasons.