unk_8c/unk_90 flags are parent columns
bloerwald opened this issue · comments
from wowdev/renderservice#10 via @Shauren:
bool HasParentLookup;
uint ParentIdColumn;
uint ParentIdHotfixColumn;
- sed those comments to be an annotation, e.g.
$parent$
in the defs we have (only known for 8.0.1)
HasParentLookup = 1 and (int, not uint) ParentIdColumn = -1, then the column specified by ParentIdHotfixColumn is the column we use for
HasParentLookup = 1 and ParentIdColumn > 0, then the column specified by ParentIdHotfixColumn is... something else. We can debate what to name but I'm not convinced parent is the right name.
I'd also suggest these 3 fields be renamed/retyped as such:
bool HasIndexLookup;
int IndexIdColumnInFile;
int IndexIdColumnInClient;
HasParentLookup = 1 and ParentIdColumn > 0, then the column specified by ParentIdHotfixColumn is...
In this case its always equal to ParentIdColumn
as for "hotfix" - its used for hotfixes (ClientDbReply, ClientHotfixMessage, ClientAvailableHotfixes) - the stuff that goes into DBCache.bin
see pull request for updated merge of parent
and relation
and generalised annotations.