world-class / compass

Compass is a suite of tools for students enrolled in the University of London's online BSc in Computer Science program.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Escape all values in HTML

GHSam opened this issue · comments

commented

I don't know if you want to but it might be worth having EJS escape all output just as a precaution to avoid any potential XSS issues.

The code looks safe but escaping all output would prevent any issues if some user input did accidentally sneak in. I can create a PR for it if you want to do it.

@GHSam you are talking about changing all instances of <%- to <%= correct? So <%- foo %> becomes <%= foo %>? I would merge such a PR.