Improve authentication process
ankush opened this issue · comments
Some suggestions received:
- [ ] Password double-typing to improve accessibility.
- [ ] Fix duplicate alerts for account/profile verification.
- [ ] Show proper errors in login/registration forms
- [ ] Account creation form: Change the label of the button from "Submit" to "Create account"
- [ ] Use red alerts only if an error occurred, use amber or blue otherwise
- [ ] "Already an account?" -> "Already have an account?"
- Allow logins with slack. Since we are already using it for account verification it would be a good idea to let users log in directly with Slack.
When I was changing the submit review form to include author I noticed something relevant to this issue.
If a new review submission query fails the user get's logged out. Normally the submission shouldn't fail. In my case I had an SQL syntax error which I then fixed and had no problems. So I don't think we should handle this exception because the real solution is probably always going to be fixing the query failure.
But I didn't expect this and it wasn't obvious why that happened, so I wanted to document.
- Account creation form: Change the label of the button from "Submit" to "Create account"
- Use red alerts only if an error occurred, use amber or blue otherwise
- "Already an account?" -> "Already have an account?"
Just documenting some private discussions.
We will remove local authentication and solely rely on Slack for authentication. I'll be submitting a PR for this soon.