Step for creating the PRs in the host apps is producing unexpected text when rendering the checklist
fluiddot opened this issue · comments
As you can see in the attached screenshot, there's an extra text (%!(EXTRA string=24.4)) at the end of the step.
For reference, I ran the following command:
gbm-cli render checklist -d 2024/03/08 -V 24.4 -m "Beta fix" -v 1.114.1
For reference, I ran the following command:
gbm-cli render checklist -d 2024/03/08 -V 24.4 -m "Beta fix" -v 1.114.1
Based on the output, it seems like the command was not expecting both -V and -v flags to be passed. Go considers extra parameters as a format error with %!(EXTRA string=xx).
It looks like the -V 24.4 flag was considered an extra parameter for the checklist command, and it was discarded in the output as a format error.
@fluiddot Sorry you ran into this error, but thanks for the report. Out of curiosity, do you recall any steps that prompted you to use both -V and -v flags together for the following command?
gbm-cli render checklist -d 2024/03/08 -V 24.4 -m "Beta fix" -v 1.114.1
No worries if not, but I think this will help us improve any documentation or prompts in the CLI tool.
@jhnstn I think we can clarify the expected available flags on the render checklist command README. I can help update the docs, but just wanted to get your input on the extra params.
@fluiddot Sorry you ran into this error, but thanks for the report. Out of curiosity, do you recall any steps that prompted you to use both
-Vand-vflags together for the following command?
gbm-cli render checklist -d 2024/03/08 -V 24.4 -m "Beta fix" -v 1.114.1
Not that I recall. I used both -V and -v because I was creating a beta fix version, which I presumed that it required setting both the host app version and release version.