wordpress-mobile / MediaPicker-iOS

WPMediaPicker is an iOS controller that allows capture and picking of media assets.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Video is poor quality - add option to choose video quality

DavidTomic opened this issue · comments

Expected behavior

Have option to choose video quality.

Actual behavior

Video quality is poor.

Steps to reproduce the behavior

Start WPNavigationMediaPickerViewController and take video.

Tested on [device], iOS [version], WPiOS [version]

iPhone 5, ios 9.

I made "hack" and fork this repository and used:
options.deliveryMode = PHVideoRequestOptionsDeliveryModeHighQualityFormat; in method - (WPMediaRequestID)videoAssetWithCompletionHandler:(WPMediaAssetBlock)completionHandler

And also in WPMediaPickerViewController.m I added imagePickerController.videoQuality = UIImagePickerControllerQualityTypeHigh; in method - (void)showMediaCaptureViewController.

Thanks for reporting this, I will follow up with a PR soon with your suggestions.

@astralbodies I think David found the same issue you noticed a while ago.

@DavidTomic just pushed a PR for this #166