sideEffects: false incorrect

[pfg]

all.js and common.js have side effects that get deleted when tree-shaking because of this option in package.json

[Titus]

which parts?

[pfg]

all.js and common.js remove all their language imports and end up registering nothing except plaintext. I think the correct option for sideEffects is

"sideEffects": ["lib/all.js", "lib/common.js"],

[Titus]

Could you check by changing the package.json in your node_modules locally which configuration works for your bundler (and share what bundler that is)?
I’m up for changing this but I’d appreciate publishing something more certain than an “I think X will work”!

[pfg]

It works with "sideEffects": ["lib/all.js", "lib/common.js"],. I tested and

• the bundle size is large, as expected, rather than being tiny
• getLanguages returns the full language list
• languages seem to work.

[Titus]

Could you clarify which bundler that is?

[pfg]

I'm using vite which uses rollup internally

[Titus]

released!