Unexpected php highlight

[Cong Zhang]

The result of refractor.highlight(...) is unexpected.

see demo: https://codesandbox.io/s/unexpected-php-highlight-9x2u4

[Titus]

Seems to be related to placeholders:

refractor/lang/php.js

Lines 121 to 129 in 48d2d90

   Prism.languages['markup-templating'].buildPlaceholders( 
     env, 
     'php', 
     phpPattern 
   ) 
 }) 
 Prism.hooks.add('after-tokenize', function(env) { 
   Prism.languages['markup-templating'].tokenizePlaceholders(env, 'php') 
 }) 

Not sure if we can fix the after-tokenize phase.

[Titus]

I tracked this down to css-extras:

refractor/lang/css-extras.js

Line 79 in 32c65ff

 number: /-?[\d.]+/ 

And I can reproduce it with normal Prism as well:

I’ll raise an issue there!

[Titus]

I raised PrismJS/prism#2008.
As this is an issue there, I don’t think it’s needed to keep it open here.
Follow their issue for updates, and when there’s a fix released, it’ll be pulled into refractor!