woodruffw / ff2mpv

A Firefox/Chrome add-on for playing URLs in mpv.

Home Page:https://addons.mozilla.org/en-US/firefox/addon/ff2mpv/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Question] How should I set the args syntax if I want to use the MPV variable?

sun95n opened this issue · comments

commented

Hi, I am using the umpv script to use the same window when opening many videos. The problem is that, if I want to add custom options, I have to edit line 84 of this script or use the MPV variable. The latter is what I want to achieve in ff2mpv.py but unfortunately no video opens.

I used the first method to add the --ontop flag. It works well.

args = ["umpv", url]

The second method works fine when run in a terminal, but not when editing ff2mpv.py Am I setting the syntax right?

args = ["env MPV="mpv --ontop" umpv", url]
commented

Hi @sun95n,

Your second method wouldn't work because you're trying to pass a whole shell line as the executable path, which is the first array element (also invalid syntax due to improper quoting).

I think the array should look like this:

args = ["env", "MPV=mpv --ontop", "umpv", url]

Does that work?

commented

It worked! Thank you very much for your help.

Glad to hear it; thanks @Roman2K for answering!