Videos don't open at all

Question

Videos don't open at all

Raudonkepuris opened this issue 3 years ago · comments

Raudonkepuris commented 3 years ago

I had two problems with installation:

install.sh script tried installing to "/home/william/scripts/ff2mpv", I had to install it manually and it still didn't work.
I had to delete the argument "--no-terminal" (from the python script) to get it to work.

It might be related to the fact that I have zsh alias "mpv="devour mpv"".

My setup is:
Artix runit, dwm, st, mpv 1:0.33.0-3, youtube-dl 2020.12.22-1.

WernerRomling · Answer 1 · Fri Dec 25 2020 22:09:37 GMT+0800 (China Standard Time)

I'm on Kubuntu and I already tried a lot of things but when firefox executes the python script it seems like the script is running with privileges. becuse yt-dl_hook does not have permissions and it only has this problem when running mpv with sudo.

William Woodruff · Answer 2 · Sat Dec 26 2020 11:30:15 GMT+0800 (China Standard Time)

The first sounds like a bug in the install script, which @Atemu recently modified. Any thoughts? I don't use it personally, so I won't be of much help with it.

I'm not sure about the second. What does it say when you try to pass --no-terminal manually?

William Woodruff · Answer 3 · Sat Dec 26 2020 11:31:51 GMT+0800 (China Standard Time)

I'm on Kubuntu and I already tried a lot of things but when firefox executes the python script it seems like the script is running with privileges. becuse yt-dl_hook does not have permissions and it only has this problem when running mpv with sudo.

@Werner1201 This is not a supported configuration. You shouldn't be running Firefox, or MPV, or youtube-dl as a root user or with any sort of effective root permissions. I followed up on your separate issue; let me know if that helps.

Atemu · Answer 4 · Sat Dec 26 2020 16:15:29 GMT+0800 (China Standard Time)

I just ran the install script again and it worked as expected. Could you bash -x it and give us the resulting JSON Raudonkepuris?

Does mpv work without the alias? It only exists in interactive zsh sessions and nowhere else.

WernerRomling · Answer 5 · Sat Dec 26 2020 20:16:15 GMT+0800 (China Standard Time)

I just ran the install script again and it worked as expected. Could you bash -x it and give us the resulting JSON Raudonkepuris?

Does mpv work without the alias? It only exists in interactive zsh sessions and nowhere else.

Raudonkepuris · Answer 6 · Sat Dec 26 2020 21:30:55 GMT+0800 (China Standard Time)

I'm not sure about the second. What does it say when you try to pass --no-terminal manually?

It played in all scenarios I tried (I had disabled the alias while testing)

I just ran the install script again and it worked as expected. Could you bash -x it and give us the resulting JSON Raudonkepuris?

Does mpv work without the alias? It only exists in interactive zsh sessions and nowhere else.

Mpv does work both with and without the alias, the picture above confirms that.
And the extension works when installed with bash.

It might've been a whole other problem that it wouldn't play videos, but I can't think of anything else I did while fixing it. Maybe it was zsh's problem.

William Woodruff · Answer 7 · Sun Dec 27 2020 01:09:10 GMT+0800 (China Standard Time)

It might've been a whole other problem that it wouldn't play videos, but I can't think of anything else I did while fixing it. Maybe it was zsh's problem.

I'm not sure, but the script definitely wasn't written with zsh in mind originally. It wouldn't surprise me if it did the wrong thing.

I'm happy to accept a PR that rewrites it in POSIX sh or, even better, uses a Makefile to drive installation.

William Woodruff · Answer 8 · Sun Dec 27 2020 01:10:02 GMT+0800 (China Standard Time)

(Closing since it sounds like it's working now.)