wonday / react-native-pdf

A <Pdf /> component for react-native

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

iOS New Architecture/Fabric build error: no member named 'enableDoubleTapZoom'

timbocole opened this issue · comments

What react-native version are you using?
RN0.74.0

What react-native-pdf version are you using?
v6.7.5

What platform does your issue occur on? (android/ios/both)
ios

Describe your issue as precisely as possible :
Building with New Architecture enabled/Fabric results in compilation error.

app/node_modules/react-native-pdf/ios/RNPDFPdf/RNPDFPdfView.mm:139:42: error: no member named 'enableDoubleTapZoom' in 'facebook::react::RNPDFPdfViewProps'
    if (_enableDoubleTapZoom != newProps.enableDoubleTapZoom) {
                                ~~~~~~~~ ^
app/node_modules/react-native-pdf/ios/RNPDFPdf/RNPDFPdfView.mm:140:41: error: no member named 'enableDoubleTapZoom' in 'facebook::react::RNPDFPdfViewProps'
        _enableDoubleTapZoom = newProps.enableDoubleTapZoom;

I was having the same problem

@timbocole fix solved for me

Resolved by my PR #832 however will leave this issue open until it is included in a published release

commented

Cool, the patch works on my end!