bug: symbol link "../../" on windows is incorrect
commu2005 opened this issue · comments
fix: symbol link "../../" on windows is incorrect. You should invoke os.path.normpath() to change "../../" to "..\..\" on windows
libpip2pi\commands.py after line 371:
symlink_source = os.path.join("../../", pkg_basename)
should append this line:
symlink_source = os.path.normpath(symlink_source)
before:
absl-py-1.0.0.tar.gz [../../absl-py-1.0.0.tar.gz]
absl_py-1.0.0-py3-none-any.whl [../../absl_py-1.0.0-py3-none-any.whl]
after:
absl-py-1.0.0.tar.gz [....\absl-py-1.0.0.tar.gz]
absl_py-1.0.0-py3-none-any.whl [....\absl_py-1.0.0-py3-none-any.whl]
libpip2pi/commands.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/libpip2pi/commands.py b/libpip2pi/commands.py
index 864b6ec..cf80a70 100644
--- a/libpip2pi/commands.py
+++ b/libpip2pi/commands.py
@@ -369,6 +369,7 @@ def _dir2pi(option, argv):
symlink_target = os.path.join(pkg_dir, pkg_basename)
symlink_source = os.path.join("../../", pkg_basename)
-
symlink_source = os.path.normpath(symlink_source) if option.use_symlink: try_symlink(option, symlink_source, symlink_target) else: